Bug 360862 - Settings -> Wallpaper: Switch from one declarative wallpaper to another does not work directly
Summary: Settings -> Wallpaper: Switch from one declarative wallpaper to another does...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image Wallpaper (show other bugs)
Version: 5.5.4
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-22 17:56 UTC by Gregor Mi
Modified: 2017-01-03 08:41 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.8.6


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Mi 2016-03-22 17:56:14 UTC
1. Settings -> Wallpaper
2. choose Hunyango
3. Save
4. Settings -> Wallpaper again
5. choose Haenau
ACTUAL: "Apply" button will not get enabled, "OK" button has no effect.

Workaround: Change Wallpaper first to a Type other than Haenau or Hunyango and then it works.

It seems that Hunyango and Haenau are two instances of a common base type and the dialog does not notice that the instance was switched.
Comment 1 Tony 2016-08-06 20:29:16 UTC
Can confirm this on KDE Neon 5.7.
Comment 2 Kai Uwe Broulik 2017-01-01 22:06:13 UTC
The apply button actually gets enabled but does nothing.
Comment 3 Kai Uwe Broulik 2017-01-03 08:41:12 UTC
Git commit 76ac242c37b71b7dcdfaa4f78afd365b43610d6f by Kai Uwe Broulik.
Committed on 03/01/2017 at 08:35.
Pushed by broulik into branch 'Plasma/5.8'.

[Containment Appearance] Make sure to always load a config view

If StackView is empty, currentItem will be null and we would break all over the place.
This can happen when you have a wallpaper without config, so "sourceFile" would stay empty
and thus onSourceFileChanged wouldn't be triggered and we wouldn't load anything into our StackView.
FIXED-IN: 5.8.6

Differential Revision: https://phabricator.kde.org/D3911

M  +4    -1    desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

https://commits.kde.org/plasma-desktop/76ac242c37b71b7dcdfaa4f78afd365b43610d6f