Bug 360853 - Hardcoded white background color in default theme of messageviewer
Summary: Hardcoded white background color in default theme of messageviewer
Status: CONFIRMED
Alias: None
Product: kdepim
Classification: Applications
Component: messageviewer (show other bugs)
Version: GIT (master)
Platform: Gentoo Packages Linux
: NOR minor
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-22 14:09 UTC by Vadim A. Misbakh-Soloviov (mva)
Modified: 2023-01-03 08:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim A. Misbakh-Soloviov (mva) 2016-03-22 14:09:54 UTC
I think, hardcoding white background color for message viewer is a bad idea, because it produces bad behavior on dark themes:

1) results in ugly look (because font colors are taken from user's settings, and so light font color, light action icons and so on renders on white backgound).

2) very contrasts with another interface colorscheme and very hurt eyes at night.

3) don't brake html emails (I talked with Laurent Montel about that issue via email, and he said that removing line with hardcoded white bg from theme css (to use system background) breaks html emails, but I've tested it with many HTML emails (even highly formatted, with menus and so on) and neither of them was broken. They just using my system define bg color and default font color (if not redefined, as for menus).

So, I want to discuss that here (and give people with dark themes, like me) the place to say if they like or dislike forced white bg.

Reproducible: Always
Comment 1 Vadim A. Misbakh-Soloviov (mva) 2016-03-23 09:25:12 UTC
fixed as sideload of bug #360851
Comment 2 Laurent Montel 2016-03-23 11:58:47 UTC
It was a bad commit indeed.
I will revert for sure this part soon.
Comment 3 Vadim A. Misbakh-Soloviov (mva) 2017-02-11 09:41:56 UTC
It seems, there is still hardcoded white background color (it shows, after messageviewer starting to load email content, and before it shows it (with applied messageviewer theme).

So:
1) it still hurts eyes
2) it is white scrollbar even in themed view because of that.

// Although, now I use KMail with QtWebengine, and now QtWebkit like before, if it makes sense
Comment 4 Vadim A. Misbakh-Soloviov (mva) 2017-02-11 09:45:27 UTC
(In reply to Vadim A. Misbakh-Soloviov (mva) from comment #3)
> and now QtWebkit like before,
I meant "and not"
Comment 5 Justin Zobel 2022-10-30 00:37:44 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 6 Vadim A. Misbakh-Soloviov (mva) 2022-11-12 20:21:40 UTC
Yes, I do.

Although, now package providing the theme for messageveiewer calls "messagelib", and I can't select proper product and actual version in bug's description)