Bug 360700 - Disable "Unify outputs" when there is only one display
Summary: Disable "Unify outputs" when there is only one display
Status: RESOLVED FIXED
Alias: None
Product: KScreen
Classification: Plasma
Component: kcm (show other bugs)
Version: 1.0.5
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-18 11:37 UTC by Tristan Miller
Modified: 2016-10-16 22:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.8.2
kde: Usability?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tristan Miller 2016-03-18 11:37:23 UTC
The "Display Configuration" section of the "Display and Monitor" module contains a button labelled "Unify outputs".  This button is always active, but from what I can tell it is effective only when there is more than one display.  I suggest that the button should be deactivated whenever there is only one display.

I am using System Settings 4.11.20 on KDE 4.14.9 as packaged by openSUSE 13.2.

Reproducible: Always
Comment 1 Kai Uwe Broulik 2016-03-18 11:59:34 UTC
Shouldn't it also rather be a check box?
Comment 2 Tristan Miller 2016-03-18 13:06:32 UTC
Yes, a checkbox seems more appropriate to me.  But again, it should be deactivated when there's only one display.
Comment 3 Sebastian Kügler 2016-03-18 14:11:09 UTC
Not sure about the checkbox, the "unify outputs" just sync the size and position between the outputs, there's no such mode as "clone mode", so a checkbox would be misleading and make the whole thing less flexible.

Otherwise, yes, button should be disabled for only one output.
Comment 4 Sebastian Kügler 2016-10-16 22:15:35 UTC
Git commit e886c69e9a9bbd033f5a4d5dd12df0e4d7521b1f by Sebastian Kügler.
Committed on 16/10/2016 at 22:15.
Pushed by sebas into branch 'master'.

Disable unify button when only one output is connected
FIXED-IN:5.8.2

M  +1    -0    kcm/src/widget.cpp

http://commits.kde.org/kscreen/e886c69e9a9bbd033f5a4d5dd12df0e4d7521b1f
Comment 5 Sebastian Kügler 2016-10-16 22:16:41 UTC
Git commit 6dcc9b19be52fdf5b4c8148124758f7392646719 by Sebastian Kügler.
Committed on 16/10/2016 at 22:16.
Pushed by sebas into branch 'Plasma/5.8'.

Disable unify button when only one output is connected
FIXED-IN:5.8.2

M  +1    -0    kcm/src/widget.cpp

http://commits.kde.org/kscreen/6dcc9b19be52fdf5b4c8148124758f7392646719