Bug 360683 - Cannot deselect (un-highlight) a date in the Calendar popup
Summary: Cannot deselect (un-highlight) a date in the Calendar popup
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Calendar (show other bugs)
Version: 5.6.2
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-18 02:55 UTC by Najjar
Modified: 2016-04-09 16:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of Calendar popup with the previous day selected (27.30 KB, image/png)
2016-03-18 02:56 UTC, Najjar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Najjar 2016-03-18 02:55:29 UTC
When clicking on the digital clock applet and the calendar pops up, the month grid shows each day in a square by day of the month (i.e. a calendar!)

When clicking on one of those squares, it'll be highlighted (selected). But then there's no way to deselect. So when time passes and the next day comes, the selected day will still be there (until logging out, or the month passes)

It can be a bit confusing, as the selected day is in blue, and the actual day is in grey (and every time my eye goes to the blue square and ignores the grey one, I don't even notice it sometimes)

In the attached image note how the date is 18/3, while 17/3 is highlighted. I didn't select it on purpose, it was selected (by accident probably) the previous day. The highlight didn't go away after midnight, nor obviously when I close the popup

Reproducible: Always
Comment 1 Najjar 2016-03-18 02:56:31 UTC
Created attachment 97955 [details]
Screenshot of Calendar popup with the previous day selected
Comment 2 Martin Klapetek 2016-03-18 14:19:36 UTC
Thanks for the report

This certainly was possible, but must have gotten broken.
Comment 3 Kai Uwe Broulik 2016-03-18 15:25:10 UTC
Also, what's up with the font size there :0
Comment 4 Martin Klapetek 2016-03-18 15:34:43 UTC
I think that's partly an illusion because the top margin (which is the same as the bottom) is covered by the blue stripe and you can't see the edge of the panel, so it looks a bit off. Nevertheless seems a bit too big overall.

The different font sizes should be fixed now.
Comment 5 Najjar 2016-03-18 17:41:44 UTC
If you mean the font of the clock, I'm not bothered by it. I've gotten used to it, and I don't think it's very big

However, I do miss the ability to edit time/date formats like in KDE4, which was lost after moving to Qt5. I'm more bothered by the movement of the systray when the hour turns to double digits (e.g. 9:59 -> 10:00), which I used to set in time settings to be always double digits (09:59 -> 10:00).
Comment 6 Martin Klapetek 2016-03-31 02:54:22 UTC
Git commit cff18c2cd28e8676cbcc0713ba45efde6cf09db0 by Martin Klapetek.
Committed on 31/03/2016 at 02:53.
Pushed by mklapetek into branch 'master'.

[calendar] Fix calendar applet not clearing selection when hiding

This removes some old cruft that is not really used and serves
basically only as a bool property for checking if it's null and
wheter it equals the last activated date.

This can be done without it by simply resetting the current selected
date (another property) to "today".

REVIEW: 127455

M  +2    -8    src/declarativeimports/calendar/qml/DayDelegate.qml
M  +0    -9    src/declarativeimports/calendar/qml/DaysCalendar.qml
M  +1    -1    src/declarativeimports/calendar/qml/MonthView.qml

http://commits.kde.org/plasma-framework/cff18c2cd28e8676cbcc0713ba45efde6cf09db0
Comment 7 Martin Klapetek 2016-03-31 02:57:39 UTC
Git commit d3beb0b647a543436d3d23ab82b39a2f98a384be by Martin Klapetek.
Committed on 31/03/2016 at 02:55.
Pushed by mklapetek into branch 'Plasma/5.6'.

[calendar] Fix calendar applet not clearing selection when hiding

REVIEW: 127456

M  +0    -1    applets/digital-clock/package/contents/ui/CalendarView.qml

http://commits.kde.org/plasma-workspace/d3beb0b647a543436d3d23ab82b39a2f98a384be
Comment 8 Najjar 2016-04-08 18:36:26 UTC
I've updated to v5.6.2-1 from the Arch repos, and the issue is still present.

There's a button, but clicking it doesn't take the selection back to today, neither does closing (hiding) the applet. Clicking the "today" button actually just takes me back to the current month if I flip to another one
Comment 9 Martin Klapetek 2016-04-08 18:48:51 UTC
You need to update plasma-framework to 5.21.
Comment 10 Najjar 2016-04-09 16:13:00 UTC
I didn't realize that, sorry. I'm waiting for plasma-frameworks 5.21 to be pushed to testing then stable in the next days in the Arch repos