Bug 360656 - CMake highlighting: OR/AND not highlighted after expr in ()
Summary: CMake highlighting: OR/AND not highlighted after expr in ()
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (other bugs)
Version First Reported In: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 12:18 UTC by Alexander Potashev
Modified: 2017-07-23 09:23 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/syntax-highlighting/714f17d79ab73c184bbb36adea8c3cde4989ef91
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2016-03-17 12:18:09 UTC 
If you type in "if((A AND B) OR C)", "OR" is not highlighted.

Reproducible: Always
Comment 1 Christoph Cullmann 2016-09-06 21:23:30 UTC 
I think the problem is that "Macro Args" pops context on ) but we need to push on (, too, which is not that trivial, given Macro Args is included at several places
Comment 3 Dominik Haumann 2017-06-17 14:27:35 UTC 
Git commit 714f17d79ab73c184bbb36adea8c3cde4989ef91 by Dominik Haumann, on behalf of Jonathan Poelen.
Committed on 17/06/2017 at 14:26.
Pushed by dhaumann into branch 'master'.

CMake: OR/AND not highlighted after expr in ()
Differential Revision: https://phabricator.kde.org/D6128

M  +2    -0    autotests/folding/highlight.cmake.fold
M  +3    -1    autotests/html/highlight.cmake.html
M  +2    -0    autotests/input/highlight.cmake
M  +3    -1    autotests/reference/highlight.cmake.ref
M  +24   -13   data/syntax/cmake.xml

https://commits.kde.org/syntax-highlighting/714f17d79ab73c184bbb36adea8c3cde4989ef91