Bug 360596 - Crashed when compiling with error: ‘KCoreAddons’ has not been declared
Summary: Crashed when compiling with error: ‘KCoreAddons’ has not been declared
Status: RESOLVED FIXED
Alias: None
Product: kinfocenter
Classification: Applications
Component: general (show other bugs)
Version: 5.5.95
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: David Hubner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-16 10:32 UTC by Liewyec
Modified: 2016-03-16 21:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Liewyec 2016-03-16 10:32:44 UTC 
When emerge this package it always crashesh with ang GCC is complaining about this: 
    KCoreAddons is not declared 
    "KCOREADDONS_VERSION" is not defined

 I looked in to source code and find out that the includes are in wrong order. I fixed this by moving

#include <kcoreaddons_version.h> 

above 

#if KCOREADDONS_VERSION >= QT_VERSION_CHECK(5,20,0)
#include <KCoreAddons>
#endif

in file:

/var/tmp/portage/kde-plasma/kinfocenter-5.5.95/work/kinfocenter-5.5.95/Modules/about-distro/src/Module.cpp

after that it compiles without any problem


Reproducible: Always

Steps to Reproduce:
1. emerge =kde-plasma/kinfocenter-5.5.95
2.
3.
Comment 1 Christoph Feck 2016-03-16 21:36:01 UTC 
Already fixed with commit b4994c307ce86b52e20c4afb35ff2eaf12bfd8f1 by David Edmundson.