Bug 360514 - Fade-out/fade-in when autohiding
Summary: Fade-out/fade-in when autohiding
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: 5.6.4
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-14 11:34 UTC by Yves Glodt
Modified: 2016-09-02 11:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yves Glodt 2016-03-14 11:34:00 UTC
This is purely a nice-to-have thing.

It would be nice if we could have the panel fade-out and fade-in if it's set to autohide.

The current slide-from-bottom is functionally ok. But it feels old-fashioned.

Reproducible: Always
Comment 1 Martin Klapetek 2016-03-14 16:11:27 UTC
+1 to that
Comment 2 Kai Uwe Broulik 2016-05-30 14:33:16 UTC
Looks like a kwin bug (or X being weird), the panel sets KWindowEffects::slideWindow(winId(), slideLocation, -1); after setting the _KDE_NET_WM_SCREEN_EDGE_SHOW atom, so it should slide but obviously doesn't.
Comment 3 Thomas Lübking 2016-05-30 15:08:43 UTC
> so it should slide
but
> ould have the panel fade-out and fade-in if it's set to autohide.
> slide-from-bottom [...] feels old-fashioned

afaiu the request is NOT to slide?
Comment 4 Kai Uwe Broulik 2016-05-30 15:15:20 UTC
Hmm, okay, I was confused because here it doesn't slide at all. The panel just disappears.
Comment 5 Thomas Lübking 2016-05-30 17:29:31 UTC
The window should have a _KDE_SLIDE property (caused by ::slideWindow), if it doesn't that bug is on the plasmashell side.
Comment 6 Kai Uwe Broulik 2016-05-30 21:03:57 UTC
The panel has a _KDE_SLIDE(_KDE_SLIDE) = 0xffffffff, 0x1 (top panel in this case)
Comment 7 Thomas Lübking 2016-05-30 21:46:26 UTC
Looks correct, could be added too late (after map, loosing frames)?
Do you see an animation when setting the animation speed to "Bob the turtle"?
Comment 8 Kai Uwe Broulik 2016-05-30 21:51:27 UTC
I can't see it with slow animations either.

It basically does:
xcb_change_property(c, XCB_PROP_MODE_REPLACE, winId(), atom->atom, XCB_ATOM_CARDINAL, 32, 1, &value);
KWindowEffects::slideWindow(winId(), slideLocation, -1);

Perhaps it's because the window is hidden by KWin itself in response to the edge hide thing rather than just hidden explicitly?
Comment 9 Thomas Lübking 2016-05-30 22:06:00 UTC
That rang a bell: bug #354407, see https://bugs.kde.org/show_bug.cgi?id=354407#c3 for the cause. The window is never added/removed (the way the effect waits for it)
Comment 10 Kai Uwe Broulik 2016-05-30 22:09:11 UTC
Thanks a lot, I'll have a look at the client (un)minimized approach you suggested.
Comment 11 Martin Flöser 2016-09-02 11:53:57 UTC
So the issue most talked about in this wish list (slide not working for autohiding panels) is fixed in Plasma 5.8. Which makes me say the wishlist is worksforme. Whether it should fade optionally is nothing I can decide on.