Bug 360321 - plasma toolbox respect toolbar icon size
Summary: plasma toolbox respect toolbar icon size
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Containment (show other bugs)
Version: 5.5.3
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-09 17:51 UTC by andreas
Modified: 2016-06-20 13:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
kainz.a: Usability+


Attachments
toolbox right click (44.48 KB, image/png)
2016-03-09 17:52 UTC, andreas
Details
system settings (293.97 KB, image/png)
2016-03-09 17:53 UTC, andreas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas 2016-03-09 17:51:37 UTC
the toolbox should respect the size of the toolbar icon size from the system settings. if it is not possible please use the default size (22px) and not 32px cause 32px icons are not supported in breeze icons (now).

Reproducible: Always
Comment 1 andreas 2016-03-09 17:52:04 UTC
Created attachment 97796 [details]
toolbox right click
Comment 2 andreas 2016-03-09 17:53:26 UTC
Created attachment 97797 [details]
system settings
Comment 3 Janet 2016-04-16 16:32:21 UTC
IMHO those icons should follow the "small icons" size and not the toolbar size. It is not a toolbar.
Comment 4 andreas 2016-04-16 18:05:19 UTC
So same size rhan right click, could work.
Comment 5 andreas 2016-06-14 07:10:05 UTC
any news? it the toolbox an toolbar for the desktop like in the panel burger menu or not?
Comment 6 Thomas Pfeiffer 2016-06-18 18:38:34 UTC
It is a menu, not a toolbar, and therefore should use the same size as menus in applications.
Comment 7 David Edmundson 2016-06-20 13:43:31 UTC
Git commit df9e2d1f329bbf973a377429602f9a7121107e0d by David Edmundson.
Committed on 20/06/2016 at 13:43.
Pushed by davidedmundson into branch 'Plasma/5.7'.

Don't set width and height in a layout

Summary:
Layouts adjust the size of the children by changing the width and height
replacing our bindings.

implicitWidth is the correct thing to use for layout items

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D1952

M  +2    -2    toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml

http://commits.kde.org/plasma-desktop/df9e2d1f329bbf973a377429602f9a7121107e0d