Bug 360300 - Remove "Panel Setings" menu in context menu of each panel widget
Summary: Remove "Panel Setings" menu in context menu of each panel widget
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.5.3
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-09 12:39 UTC by andreas
Modified: 2016-07-18 16:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
kainz.a: Usability+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andreas 2016-03-09 12:39:30 UTC
with right click on an widget you get edit widget and alternative, ... in addition on each widget at the panel you have panel options but therefore the burger menu is in the panel.

So please remove the panel option from each widget cause the user can change the panel setting at the burger menu.

Reproducible: Always
Comment 1 Kai Uwe Broulik 2016-03-09 12:42:06 UTC
We can just remove the addContainmentActions(*containmentMenu, event); thing but I don't know what implications that brings with it; ie. if there's other containments (like the new sys tray?) that depend on that.

But I like the cleaner look - if you want to add stuff to the panel, you can use the panel menu. If the widgets are locked, the panel settings in the context menu also don't show up anyway.
Comment 2 andreas 2016-05-13 11:34:53 UTC
burger menu means in every application you can configure something so why the user should right click to the task manager to change the panel?
If you want to offer to configure the panel from each widget than the panel options are missing when right click to the system tray.
I only think it is confusing more than it helps.
Comment 3 Thomas Pfeiffer 2016-06-14 13:32:29 UTC
The only thing that still needs to be possible to do from the context menu is unlocking a locked panel in order to get the menu button back, as there is no other way to do that.

Therefore I'd be for showing the unlock option in the context menu when locked, but remove anything else.

I'm personally not a fan of hiding the menu button when the panel is locked, but people like Jens apparently are so obsessed with getting rid of any non-essential control on their desktop that they'd be very unhappy if there were no way to hide it, so I suppose getting an extra context menu entry for unlocking is the lesser evil for them.
Comment 4 Kai Uwe Broulik 2016-06-14 19:34:32 UTC
So, can you please make a full thought-through concept of your "Edit mode" highlighting every and all (!) aspects and send it to us, I'm tired of getting those "yeah but in Edit mode it should..." bug reports. Thanks.
Comment 5 Thomas Pfeiffer 2016-06-14 19:51:59 UTC
(In reply to Kai Uwe Broulik from comment #4)
> So, can you please make a full thought-through concept of your "Edit mode"
> highlighting every and all (!) aspects and send it to us, I'm tired of
> getting those "yeah but in Edit mode it should..." bug reports. Thanks.

We will do that, but this bug is not directly related to it.

Regardless of a full-fledged edit mode, the settings stuff should be removed from the panel context menu, apart from a "Unlock Panel" option which is only shown while it's locked. The only thing that might be changed if an edit mode ever gets implemented is the wording of this option.
Comment 6 Kai Uwe Broulik 2016-06-14 20:01:32 UTC
Of course, that's why I made this patch https://phabricator.kde.org/D1869 :)
Comment 7 Thomas Pfeiffer 2016-06-14 20:59:23 UTC
(In reply to Kai Uwe Broulik from comment #6)
> Of course, that's why I made this patch https://phabricator.kde.org/D1869 :)

That is one thing, but the whole "Panel Options" submenu should be removed.
The only thing shown is "Unlock Panel" (not a submenu, just this one thing) and only if it's locked.
Comment 8 Kai Uwe Broulik 2016-06-15 10:47:28 UTC
Git commit a5b728b27fdd364ada6c55fdebcc2c28d964fabd by Kai Uwe Broulik.
Committed on 15/06/2016 at 10:42.
Pushed by broulik into branch 'master'.

[Containment Actions] Offer "Remove this panel" option only when panel is being edited

We only show the "Remove this applet" option when the panel controller is opened
to prevent the user from accidentally messing up his setup.
However, the "Remove this panel" option, albeit in a submenu, was always there and
is even more destructive.

Differential Revision: https://phabricator.kde.org/D1869

M  +7    -1    containmentactions/contextmenu/menu.cpp

http://commits.kde.org/plasma-workspace/a5b728b27fdd364ada6c55fdebcc2c28d964fabd