Bug 360025 - logindTest fails with Qt 5.6.0-rc
Summary: logindTest fails with Qt 5.6.0-rc
Status: RESOLVED FIXED
Alias: None
Product: kscreenlocker
Classification: Plasma
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-03 13:31 UTC by Heiko Becker
Modified: 2016-03-03 16:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Becker 2016-03-03 13:31:47 UTC
logindTest fails with Qt-5.6.0 here, whereas it works fine with 5.5.1. My version of kscreenlocker is 5.5.95, but it see the same error with kscreenlocker-5.5.5:

make test ARGS="-V -R ksmserver-logindTest"

Running tests...
/usr/x86_64-pc-linux-gnu/bin/ctest --force-new-ctest-process -V -R ksmserver-logindTest
UpdateCTestConfiguration  from :/home/heiko/Quelltexte/exherbo/git-sources/plasma/kscreenlocker/build/DartConfiguration.tcl
UpdateCTestConfiguration  from :/home/heiko/Quelltexte/exherbo/git-sources/plasma/kscreenlocker/build/DartConfiguration.tcl
Test project /home/heiko/Quelltexte/exherbo/git-sources/plasma/kscreenlocker/build
Constructing a list of tests
Done constructing a list of tests
Checking test dependency graph...
Checking test dependency graph end
test 2
    Start 2: ksmserver-logindTest

2: Test command: /home/heiko/Quelltexte/exherbo/git-sources/plasma/kscreenlocker/build/autotests/logindTest
2: Test timeout computed to be: 9.99988e+06
2: ********* Start testing of LogindTest *********
2: Config: Using QtTest library 5.6.0, Qt 5.6.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.0)
2: PASS   : LogindTest::initTestCase()
2: FAIL!  : LogindTest::testLockUnlock() Compared values are not the same
2:    Actual   (lockSpy.count()): 1
2:    Expected (2)              : 2
2:    Loc: [/home/heiko/Quelltexte/exherbo/git-sources/plasma/kscreenlocker/autotests/logindtest.cpp(51)]
2: PASS   : LogindTest::testLogindPresent()
2: PASS   : LogindTest::testRegisterUnregister()
2: PASS   : LogindTest::cleanupTestCase()
2: Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted
2: ********* Finished testing of LogindTest *********
1/1 Test #2: ksmserver-logindTest .............***Failed    0.22 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.22 sec

The following tests FAILED:
          2 - ksmserver-logindTest (Failed)
Errors while running CTest
Makefile:119: recipe for target 'test' failed
make: *** [test] Error 8

Reproducible: Always
Comment 1 Martin Flöser 2016-03-03 15:23:55 UTC
Thanks for spotting. I just run the test with latest checkout and unfortunately I can confirm.
Comment 2 Martin Flöser 2016-03-03 15:31:25 UTC
Git commit 18c35d3e146b2324d65340e082c329977abe3acb by Martin Gräßlin.
Committed on 03/03/2016 at 15:31.
Pushed by graesslin into branch 'Plasma/5.6'.

[autotest] Fix LogindTest with Qt 5.6

Apparently we need to explicitly wait after each lock, otherwise we
lose a signal.

I do hope it also works with older Qt, CI system will tell us.

M  +1    -0    autotests/logindtest.cpp

http://commits.kde.org/kscreenlocker/18c35d3e146b2324d65340e082c329977abe3acb
Comment 3 Martin Flöser 2016-03-03 15:49:30 UTC
and CI is also happy with Qt 5.4
Comment 4 Heiko Becker 2016-03-03 16:16:53 UTC
(In reply to Martin Gräßlin from comment #2)
> Git commit 18c35d3e146b2324d65340e082c329977abe3acb by Martin Gräßlin.
> Committed on 03/03/2016 at 15:31.
> Pushed by graesslin into branch 'Plasma/5.6'.
> 
> [autotest] Fix LogindTest with Qt 5.6

Thanks for the quick fix. Already included the patch downstream.