Bug 359951 - ktorrent web interface displays no icons
Summary: ktorrent web interface displays no icons
Status: RESOLVED WORKSFORME
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: 4.3.1
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 13:37 UTC by Denis M. (Phr33d0m)
Modified: 2022-11-30 05:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Denis M. (Phr33d0m) 2016-03-01 13:37:32 UTC
Hello, KTorrent's web interface doesn't properly handle the icons thus modern web browsers don't display any icons.

Reproducible: Always

Steps to Reproduce:
1. Enable Web Interface
2. Use a web browser and have .svg icons pack (breezer - plasma 5?)
3. Screenshot: http://i.imgur.com/upH7UUR.png

Actual Results:  
After the (ajax?) request the icons are (incorrectly) returned as type/xml to the browser.


A proposed solution would be to add svg support to ExtensionToContentType():

At: https://github.com/KDE/ktorrent/blob/master/plugins/webinterface/httpserver.cpp#L257

```
        else if (ext == "svg")
            return "image/svg+xml";
```

would be enough I guess...

Regards.
Comment 1 Yaroslav Sidlovsky 2016-12-01 14:53:52 UTC
I can confirm this bug.

$ curl -s -I -X GET "http://localhost:8080/icon?name=view-refresh&size=1"
HTTP/1.1 200 OK
Cache-Control: private
Content-Length: 1216
Date: Thu, 01 Dec 2016 14:51:18 UTC
Expires: Thu, 01 Dec 2016 15:51:18 UTC
Last-Modified: Sun, 02 Oct 2016 10:42:33 UTC
Server: KTorrent/4.3.1
Set-Cookie: KT_SESSID=964942857
Comment 2 Yaroslav Sidlovsky 2016-12-01 15:06:56 UTC
There is my PR: https://github.com/KDE/ktorrent/pull/2
Comment 3 Justin Zobel 2022-10-31 04:31:48 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 4 Bug Janitor Service 2022-11-15 05:15:04 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2022-11-30 05:16:33 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!