Bug 359943 - New FindIsoCodes.cmake file requires cmake >= 3.4
Summary: New FindIsoCodes.cmake file requires cmake >= 3.4
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Digital Clock (show other bugs)
Version: master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 02:09 UTC by Christian Butcher
Modified: 2016-04-29 16:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Butcher 2016-03-01 02:09:20 UTC 
The new FindIsoCodes.cmake file introduced by commit fea67bd2ae7549e88952ac6dbcf90392d0ee1458 to plasma-workspace uses the 'pkg_get_variable' function, which is first available in cmake v3.4.

Either the use of the function should be removed or the cmake version requirement should be bumped (but it's a pretty big bump).

Reproducible: Always

Steps to Reproduce:
1. Try to run cmake in git-master plasma-workspace with a cmake < 3.4
2. CMake fails with 'Unknown CMake command "pkg_get_variable".'
Comment 1 Martin Klapetek 2016-03-01 13:32:04 UTC 
You are correct, thanks for the report
Comment 2 David Edmundson 2016-04-29 16:15:28 UTC 
pkg_get_variable was removed in 
09e58f7f33658fec6291213636989c715b32b7e2