Bug 359906 - Applets lost "configurationRequired" functionality in Plasma5
Summary: Applets lost "configurationRequired" functionality in Plasma5
Status: CONFIRMED
Alias: None
Product: plasmashell
Classification: Unclassified
Component: Desktop Containment (show other bugs)
Version: 5.5.4
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-28 22:47 UTC by Friedrich W. H. Kossebau
Modified: 2020-11-19 04:01 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2016-02-28 22:47:44 UTC
While Plasma::Applet still has the API from KDE4 times (`Applet::configurationRequired()`, `Applet::setConfigurationRequired(bool needsConfiguring, const QString &reason)`), there is no `Plasmoid.configurationRequired` property on QML level.
And setting the property from C++ also has no effect in the UI, at least to what I can see.

It might be nice to have this property back in full swing, so there is a consistent way to mark applets from the code which have no sane default and first need some setting to be useful.

Examples: comic applet & weather applet

Reproducible: Always
Comment 1 Kai Uwe Broulik 2016-02-29 00:04:43 UTC
The API is actually meant to be used imperatively, ie. you call plasmoid.setConfigurationRequired(true, i18n("reason")), I think there should be two distinct properties on the Plasmoid attached object

however the actual code that is supposed to do that looks like:

void AppletPrivate::showConfigurationRequiredMessage(bool show, const QString &reason)
{
    // reimplemented in the UI specific library
    Q_UNUSED(show)
    Q_UNUSED(reason)
}

Looks like we have one week to fix this for 5.6 if it's not already too late.
Comment 2 Justin Zobel 2020-11-19 04:01:19 UTC
(In reply to Kai Uwe Broulik from comment #1)
> The API is actually meant to be used imperatively, ie. you call
> plasmoid.setConfigurationRequired(true, i18n("reason")), I think there
> should be two distinct properties on the Plasmoid attached object
> 
> however the actual code that is supposed to do that looks like:
> 
> void AppletPrivate::showConfigurationRequiredMessage(bool show, const
> QString &reason)
> {
>     // reimplemented in the UI specific library
>     Q_UNUSED(show)
>     Q_UNUSED(reason)
> }
> 
> Looks like we have one week to fix this for 5.6 if it's not already too late.

Kai was this merged into 5.6 or a later version?