Bug 359837 - right click => remove application not available (or working)
Summary: right click => remove application not available (or working)
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) widget (other bugs)
Version First Reported In: 5.5.4
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
: 373278 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-02-26 19:08 UTC by Rex Dieter
Modified: 2017-02-06 17:09 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rex Dieter 2016-02-26 19:08:34 UTC
Finally looked into why I didn't have any 'right click' => 'remove application' PackageKit integraiton working in kickoff.

Problem 1:
code in plasma-desktop/applets/kicker/plugin/appentry.cpp wrapped in
#ifdef PackageKit5_FOUND
...
#endif
was seemingly not getting executed.  It appears that config-workspace.h header defining that is never included.  Adding
#include <config-workspace.h>
to the top of appentry.cpp seemed to have fixed that

Problem 2:  now I do see 'remove application' entry in kickoff right click menu, but it doesn't seem to work.  For example, trying to remove kbounce for example, yields an error dialog:
Error - KIOExec
Uknown host kbounce: Host not found

Reproducible: Always
Comment 1 Kai Uwe Broulik 2016-02-26 19:45:15 UTC
Git commit 1b5307e78dacea388c18c239a7f4b544686bc748 by Kai Uwe Broulik.
Committed on 26/02/2016 at 19:41.
Pushed by broulik into branch 'Plasma/5.5'.

[Kickoff] Add removeApplicationCommand from Kicker

This was forgotten and thus uninstalling applications didn't work
FIXED-IN: 5.5.5

M  +5    -1    applets/kickoff/package/contents/config/main.xml

http://commits.kde.org/plasma-desktop/1b5307e78dacea388c18c239a7f4b544686bc748
Comment 2 Kai Uwe Broulik 2016-02-26 19:46:58 UTC
As for the other part, it's a straight-forward fix, thanks for your investigation! It's working locally here now.

Unfortunately, the code in there performs a blocking query to package kit and doing exec() from QML is a big no-no and has caused lots of problems in the past; moreover it now takes several seconds when I right-click an application entry, so unfortunately this is not something we can just enable for a patch release but we need to find a better solution for a later release.
Comment 3 Kai Uwe Broulik 2017-01-02 00:23:00 UTC

*** This bug has been marked as a duplicate of bug 373278 ***
Comment 4 Kai Uwe Broulik 2017-01-02 00:23:33 UTC
Urgh, marked the wrong way round.
Comment 5 Kai Uwe Broulik 2017-01-02 00:23:54 UTC
*** Bug 373278 has been marked as a duplicate of this bug. ***
Comment 6 Eike Hein 2017-01-02 11:51:09 UTC
Fixed with https://git.reviewboard.kde.org/r/129697/, right?
Comment 7 Kai Uwe Broulik 2017-02-06 17:09:12 UTC
Yup, there's a "Manage $app" context menu entry nowadays that leads into Discover.