Bug 359559 - Move tool should move all selected layers
Summary: Move tool should move all selected layers
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (other bugs)
Version First Reported In: 2.9.11
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-19 00:27 UTC by katearcher89
Modified: 2016-04-05 11:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description katearcher89 2016-02-19 00:27:29 UTC
If I choose a couple of layers and use move tool with "move current layer" option the tool moves only one of the layers, the layer that was selected last.

What's even more confusing, if the option "move the whole group" is selected, layers(under the cursor) can be moved that way regardless the fact what layers was chosen.


Reproducible: Always

Steps to Reproduce:
1.Create two layers
2. Select both of them
3. Try to use move tool

Actual Results:  
Only one of the layers moves

Expected Results:  
If several layers are chosen, move tool will move all of the layers that was selected, not the last selected only.

I suppose the behaviour of the tool should be altered to be able to move selected layers by default or at least add another option to the tool to move selected layers, not just layers that are situated under the cursor.
Comment 1 Halla Rempt 2016-03-07 07:43:31 UTC
Yes, in 2.9, the move tool doesn't know about multiple selected layers. That is something that should be fixed in 3.0.
Comment 2 Raghavendra kamath 2016-04-02 06:43:32 UTC
+1 for moving selected layer all at once, in 3.0 we have got the ability to move from arrow key , This feature will add to the usability of move tool.

The current workaround is to do a quick group by Ctrl + G and move the layers, but this grouping messes up the blend modes of the layers.
Comment 3 Dmitry Kazakov 2016-04-05 11:51:33 UTC
Git commit 28d985bcb91b5ca2e4cd410e7f01db14d30ec748 by Dmitry Kazakov.
Committed on 05/04/2016 at 11:48.
Pushed by dkazakov into branch 'master'.

Implemented moving multiple selected layers at once

Please test if it breaks anything in the Move tool!
(it shouldn't though :) )

Ref T2082
CC:kimageshop@kde.org

M  +25   -2    libs/image/kis_layer_utils.cpp
M  +4    -2    libs/image/kis_layer_utils.h
M  +11   -0    libs/image/krita_utils.h
M  +8    -0    libs/ui/tool/kis_tool.cc
M  +1    -0    libs/ui/tool/kis_tool.h
M  +65   -85   plugins/tools/basictools/kis_tool_move.cc
M  +3    -1    plugins/tools/basictools/kis_tool_move.h
M  +31   -28   plugins/tools/basictools/strokes/move_stroke_strategy.cpp
M  +3    -12   plugins/tools/basictools/strokes/move_stroke_strategy.h
M  +1    -1    plugins/tools/basictools/tests/move_stroke_test.cpp

http://commits.kde.org/krita/28d985bcb91b5ca2e4cd410e7f01db14d30ec748