The order in which the filters are applied makes a huge difference in kdenlive. With the recent fix in the saving of grouped effects, (thanks very much for that, btw) I tested to see if the effects settings would survive the project being saved and re-opened. Unfortunately, this is not the case. Firstly, the grouping of my favorite filter stack was gone, and secondly, the order of which the filters were applied has changed. Reproducible: Always Steps to Reproduce: 1. Make a filter stack 2. Save stack as group 3. apply some filters to a clip on the timeline 4. apply the saved filter stack to the clip on the timeline 5. save the project 6. shut down kdenlive 7. start up kdenlive 8. load saved project 9. select clip on the timeline, and look at the filter stack. Actual Results: effects stack grouping is gone. effects order has changed. Expected Results: the effects to be restored exactly the way that they were saved.
Git commit 9862c646821aca6ac448ce5ff4fb544c64331fdc by Jean-Baptiste Mardelle. Committed on 24/02/2016 at 09:08. Pushed by mardelle into branch 'master'. Correctly save group effects M +3 -1 src/timeline/clipitem.cpp http://commits.kde.org/kdenlive/9862c646821aca6ac448ce5ff4fb544c64331fdc
Mostly fixed... At least now the groups stay groups. However, the order of the effects are not maintained. I had my group of filters after the speed effect when I saved it, and now it's loaded before the speed effect when opening up the project again.... Why have the little button on the side where you can put one filter above one another when the order is not remembered in the save file? I don't mean to sound ungrateful, I am really happy with kdenlive! The effects in the group now stays in the group, which is a massive improvement, but the group does not stay in it's relative level with the other effects on a clip.
Git commit b3f426f4c78eaa8e6da6623d006f7e9122e4a4e2 by Jean-Baptiste Mardelle. Committed on 24/02/2016 at 20:58. Pushed by mardelle into branch 'master'. Fix several problems with effects order M +26 -10 src/effectstack/collapsibleeffect.cpp M +6 -4 src/effectstack/collapsibleeffect.h M +5 -1 src/effectstack/collapsiblegroup.cpp M +42 -5 src/effectstack/effectstackview2.cpp M +4 -0 src/effectstack/effectstackview2.h M +7 -0 src/timeline/clipitem.cpp http://commits.kde.org/kdenlive/b3f426f4c78eaa8e6da6623d006f7e9122e4a4e2
I made a few changes that might help. In fact, the speed effect is a bit special because it is not really an effect in MLT. So whatever order you give, the speed effect will always be applied first. I tried to make it cleaner by disallowing to move the speed effect and attempting to always put it on top of the effect stack. If you still have problems, can you please give a description of how to reproduce the issue starting from a blank project ? I totally agree that this should be fixed for the 16.04 release, so comment here in case this is not completely solved.
I accept that speed effect should be run first. In fact, any effect that determines which frame is passed to the rest of the stack should be first. In fact, the change level button should be grayed out for speed effect. Saying all that, I just tested the latest fixes, and it's not quite right. I added the speed effect first, and then added a saved group afterwards, putting the speed effect at the top of the stack. After saving the project, and then re-starting kdenlive and loading the saved project, the speed effect now appeared below the group of effects for the clips. The project still works fine, so I don't know how hard you want to try and fix this....
Git commit 8cf2e67f2945345d7ff13d31dfcb02fb556283f9 by Jean-Baptiste Mardelle. Committed on 26/02/2016 at 18:10. Pushed by mardelle into branch 'master'. Make sure speed effect appears on top when loading project M +1 -2 src/timeline/timeline.cpp http://commits.kde.org/kdenlive/8cf2e67f2945345d7ff13d31dfcb02fb556283f9
Fixed! It looks lovely now. Thanks for the hard work!