Bug 359443 - Kimageformats conflicts
Summary: Kimageformats conflicts
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-15 18:40 UTC by demm
Modified: 2016-03-07 07:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description demm 2016-02-15 18:40:47 UTC
After this commit:
https://quickgit.kde.org/?p=kimageformats.git&a=commitdiff&h=6934d5441778a09d157836a590236e3dc8d5a492
and building kimageformats 5.19.0 with the new karchive depend, Krita and Kimageformats contain conflicting files and can no longer be co-installed.
The files already in Krita when trying to install Kimageformats:

(1/1) checking for file conflicts                                                                   [----------------------------------------------------------] 100%
error: failed to commit transaction (conflicting files)
kimageformats: /usr/lib/qt5/plugins/imageformats/kimg_kra.so exists in filesystem
kimageformats: /usr/lib/qt5/plugins/imageformats/kimg_ora.so exists in filesystem
kimageformats: /usr/share/kservices5/qimageioplugins/kra.desktop exists in filesystem
kimageformats: /usr/share/kservices5/qimageioplugins/ora.desktop exists in filesystem

Would it be possible to make kimagefomats a new build option in Krita and not hardcode to always set the use of 3rdparty/ext_fameworks/kimageformats, so that system kimageformat can be used?

Reproducible: Always

Steps to Reproduce:
1. Build latest Krita master
2. Build kimageformats 5.19.0 with karchive
3. Install of both will fail, conflicting files
Comment 1 Halla Rempt 2016-03-07 07:46:28 UTC
Git commit 751725817f92454d738e710a31d57010a2a01cf5 by Boudewijn Rempt.
Committed on 07/03/2016 at 07:45.
Pushed by rempt into branch 'rempt-osx-port'.

Remove our kimgio plugins

They are now in the kimageformats framework.

M  +0    -2    krita/integration/CMakeLists.txt
D  +0    -11   krita/integration/kimgio/CMakeLists.txt
D  +0    -88   krita/integration/kimgio/kra.cpp
D  +0    -7    krita/integration/kimgio/kra.desktop
D  +0    -39   krita/integration/kimgio/kra.h
D  +0    -5    krita/integration/kimgio/kra.json
D  +0    -87   krita/integration/kimgio/ora.cpp
D  +0    -7    krita/integration/kimgio/ora.desktop
D  +0    -38   krita/integration/kimgio/ora.h
D  +0    -5    krita/integration/kimgio/ora.json

http://commits.kde.org/krita/751725817f92454d738e710a31d57010a2a01cf5
Comment 2 Halla Rempt 2016-03-07 07:47:37 UTC
Git commit 31b695532b8b6b484fe0bb3ea71267818086761d by Boudewijn Rempt.
Committed on 07/03/2016 at 07:47.
Pushed by rempt into branch 'master'.

Remove our kimgio plugins

They are now in the kimageformats framework.

M  +0    -2    krita/integration/CMakeLists.txt
D  +0    -11   krita/integration/kimgio/CMakeLists.txt
D  +0    -88   krita/integration/kimgio/kra.cpp
D  +0    -7    krita/integration/kimgio/kra.desktop
D  +0    -39   krita/integration/kimgio/kra.h
D  +0    -5    krita/integration/kimgio/kra.json
D  +0    -87   krita/integration/kimgio/ora.cpp
D  +0    -7    krita/integration/kimgio/ora.desktop
D  +0    -38   krita/integration/kimgio/ora.h
D  +0    -5    krita/integration/kimgio/ora.json

http://commits.kde.org/krita/31b695532b8b6b484fe0bb3ea71267818086761d
Comment 3 Halla Rempt 2016-03-07 07:49:39 UTC
Yes, when I pushed our qimageio plugins to kimageformats, I should have also removed these files. Note that the 3rdparty cmakelists are only useful if you want to build Krita for distributions-agnostic packages, i.e., a distribution shouldn't even look in there. We use it for Windows, OSX and Linux AppImages.