Bug 359429 - Image history: original image's entry contains markup
Summary: Image history: original image's entry contains markup
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Database-Versioning (show other bugs)
Version: 5.0.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-15 11:25 UTC by Michal Sylwester
Modified: 2022-02-02 05:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.0.0


Attachments
Screenshot of the relevant part of the sidebar (16.46 KB, image/png)
2016-02-15 11:26 UTC, Michal Sylwester
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Sylwester 2016-02-15 11:25:05 UTC
In image history sidebar the entry for original image contains some markup: is wrapped in <qt>...</qt> with an additional <br> in the middle

Reproducible: Always

Steps to Reproduce:
1. Open versions sidebar for image with some history


Actual Results:  
Extra markup visible

Expected Results:  
No markup
Comment 1 Michal Sylwester 2016-02-15 11:26:28 UTC
Created attachment 97227 [details]
Screenshot of the relevant part of the sidebar
Comment 2 caulier.gilles 2016-02-15 12:36:19 UTC
Maik,

The markup syntax was used to bold text in listview. With Qt4 this work fine. With Qt5, it sound like a porting problem.

This syntax was inherit of Qt3 capability to use html like forma in text. It supported in Qt4 and Qt5. Look here for details :

http://doc.qt.io/qt-5/richtext-html-subset.html

Gilles Caulier
Comment 3 Maik Qualmann 2016-02-16 18:39:38 UTC
Git commit f99d96f58fe33ae122b63e09537b2ada5ca9ab7f by Maik Qualmann.
Committed on 16/02/2016 at 18:38.
Pushed by mqualmann into branch 'master'.

remove markup from image history item
FIXED-IN: 5.0.0

M  +2    -1    NEWS
M  +4    -2    libs/database/imagehistory/imagehistorygraphmodel.cpp
M  +5    -1    libs/imageproperties/versionsdelegate.cpp

http://commits.kde.org/digikam/f99d96f58fe33ae122b63e09537b2ada5ca9ab7f