Bug 359288 - Vector Text and Shape back-front arrangement resets
Summary: Vector Text and Shape back-front arrangement resets
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layers/Vector (other bugs)
Version First Reported In: 2.9.11
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-11 21:39 UTC by kyril
Modified: 2016-02-23 22:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Document showing the problem (56.50 KB, application/x-krita)
2016-02-15 05:39 UTC, T Zachmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kyril 2016-02-11 21:39:16 UTC
A rectangle within the same vector layer as a text line that is "Sent to Back" appears back on top (in front) of the text after closing and reopening the file.

Reproducible: Always

Steps to Reproduce:
New file
 - With Text Tool create a line of text (Vector layer gets created)
 - With Rectangle Tool create a rectangle over the text (different color)
 - Shape Handling Tool - select rectangle, on Tool Options docker click Send to Back.  - Rectangle moves behind the text as expected.
 - Save, close, reopen - everything still in place. From here:
 - Shape Handling Tool - click on rectangle, Bring to Front and once again Send to Back. Everything as expected.
 - Shape HTool - click in empty space to deselect everything.
 - Save, close, reopen

Actual Results:  
Rectangle is in front of the text.

Expected Results:  
Rectangle being in the back of the text.

2.9.11 git 1c398ed
Thanks!
Comment 1 wolthera 2016-02-11 23:29:04 UTC
Thanks for the report!

I can reproduce in 3.0, didn't even need to save a second time. 2016 will be vector year, so this'll go on the pile of bugs that should be fixed during it :)
Comment 2 kyril 2016-02-13 17:32:57 UTC
(In reply to wolthera from comment #1)
> 2016 will be vector year, so this'll go on the pile of bugs that should be fixed during
> it :)

Good to know - thanks!
Comment 3 T Zachmann 2016-02-14 06:41:32 UTC
I had a look at the saved file and in the saved file it is saved in the correct order. The rect is coming first and then the text. However it seems if you open the document sometimes the rect is above and sometimes it is below the text. Seems like the order of the shapes is not really kept on loading.
Comment 4 T Zachmann 2016-02-15 05:39:34 UTC
Created attachment 97223 [details]
Document showing the problem

Document showing the problem. The text shape should be the top most shape but it is either at the bottom or in the middle.
Comment 5 T Zachmann 2016-02-17 14:49:45 UTC
Git commit c82bae186f3e38ec5ade57629fbf9b3c89f77560 by Thorsten Zachmann.
Committed on 17/02/2016 at 14:49.
Pushed by zachmann into branch 'master'.

Fix bug 359288

The problem is that the zIndex of the svg shape is never set and
therefore it has the same zIndex 0 as the already existing shape. The
problem can be seen always if you create a document with 3 vector
shapes where the text shape is the most top one.
This commit loads the zIndex also for svg shapes.

M  +14   -2    libs/flake/svg/SvgShapeFactory.cpp

http://commits.kde.org/krita/c82bae186f3e38ec5ade57629fbf9b3c89f77560
Comment 6 kyril 2016-02-17 20:20:31 UTC
I think this was my first time reporting a bug and watching it die(get fixed) with my own eyes. This was awesome :D /endOfUnrelatedComments
Comment 7 Dmitry Kazakov 2016-02-20 17:28:59 UTC
Git commit a009efea1457580f39f5b880f1e39f9196293200 by Dmitry Kazakov, on behalf of Thorsten Zachmann.
Committed on 20/02/2016 at 17:26.
Pushed by dkazakov into branch 'calligra/2.9'.

Fix bug 359288

The problem is that the zIndex of the svg shape is never set and
therefore it has the same zIndex 0 as the already existing shape. The
problem can be seen always if you create a document with 3 vector
shapes where the text shape is the most top one.
This commit loads the zIndex also for svg shapes.

M  +14   -2    libs/flake/svg/SvgShapeFactory.cpp

http://commits.kde.org/calligra/a009efea1457580f39f5b880f1e39f9196293200
Comment 8 Friedrich W. H. Kossebau 2016-02-23 22:53:21 UTC
Git commit f0a0daa595c7de9efed812ff445c29f80e2b8261 by Friedrich W. H. Kossebau, on behalf of Thorsten Zachmann.
Committed on 23/02/2016 at 22:36.
Pushed by kossebau into branch 'master'.

Fix bug 359288

The problem is that the zIndex of the svg shape is never set and
therefore it has the same zIndex 0 as the already existing shape. The
problem can be seen always if you create a document with 3 vector
shapes where the text shape is the most top one.
This commit loads the zIndex also for svg shapes.

M  +14   -2    libs/flake/svg/SvgShapeFactory.cpp

http://commits.kde.org/calligra/f0a0daa595c7de9efed812ff445c29f80e2b8261