Bug 359021 - "mark as read" instead of "mark as spam" in translation for trojita
Summary: "mark as read" instead of "mark as spam" in translation for trojita
Status: RESOLVED FIXED
Alias: None
Product: i18n
Classification: Translations
Component: de (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: German-Translators
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-05 12:12 UTC by onli
Modified: 2016-02-08 07:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
trojita with two mark as read buttons (70.92 KB, image/png)
2016-02-05 12:56 UTC, onli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description onli 2016-02-05 12:12:39 UTC
In the german version for trojita the button bar at the top has two equal-looking buttons with the text "Als Gelesen markieren". Those are mislabeled, their function is  to mark as junk or non-junk.

See https://www.onli-blogging.de/uploads/trojita-readbuttons.png

They also are supposed to have an icon, that it is missing is probably a fault in my local icontheme and unrelated.
Comment 1 Frederik Schwarzer 2016-02-05 12:47:32 UTC
Wir haben diese Übersetzung, aber sie ist als "fuzzy" markiert, was bedeutet, dass sie noch keiner übersetzt hat und auch, dass sie gar nicht in der Anwendung landen sollte.

Welches Betriebssystem benutzt du? Welche Versionsnummer hat das Paket der deutschen KDE-Übersetzung?

Also, please attach the image to the bug report for later reference.
Comment 2 onli 2016-02-05 12:56:33 UTC
Created attachment 97018 [details]
trojita with two mark as read buttons
Comment 3 Frederik Schwarzer 2016-02-05 13:02:03 UTC
SVN commit 1452041 by schwarzer:

Translate missing strings.


 M  +2 -4      trojita_common.po  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1452041
Comment 4 onli 2016-02-05 13:03:49 UTC
Danke für die schnelle Antwort.

Ich habe das Bild als attachment hinzugefügt (sah aber keine Möglichkeit, das oben hinzuzufügen).

I'm using Ubuntu 14.04. language-pack-de is on 1:14.04+20150219. Trojita is on version 0.6 from their PPA.
Comment 5 Frederik Schwarzer 2016-02-05 13:07:40 UTC
So, jetzt sind die beiden fraglichen Strings übersetzt.

Danke für die Infos. Die muss ich nachher mal prüfen ... also mir anschauen, was Ubuntu da ausliefert.

Mehr dazu später.
Comment 6 Jan Kundrát 2016-02-05 13:31:12 UTC
Thanks for the quick fix, and apologies to the German translation team for blaming you for this screwup. It turned out that we forgot to instruct lrelease to drop the fuzzy strings.

Patch for review at https://gerrit.vesnicky.cesnet.cz/r/602 .
Comment 7 Frederik Schwarzer 2016-02-05 13:33:39 UTC
Ah, nice. Thanks for the info.
Comment 8 onli 2016-02-05 13:45:57 UTC
Thanks to both of you
Comment 9 Jan Kundrát 2016-02-08 07:52:18 UTC
Git commit 75e05a1edeb7051d7f112a25cac617e5d552f6bf by Jan Kundrát.
Committed on 05/02/2016 at 13:28.
Pushed by gerrit into branch 'master'.

l10n: Do not show fuzzy, unfinished strings to the user

It seems that our hand-crafted lconvert/lupdate/lrelease toolchain was
accidentally using fuzzy strings in the user-facing UI. That's bad.

Thanks to <onli@paskuda.biz> for reporting this.
Change-Id: I7e31eb92f17d2535f9803122c20bb8a2c8c1c2e2

M  +1    -1    cmake/FindQt5LinguistForTrojita.cmake

http://commits.kde.org/trojita/75e05a1edeb7051d7f112a25cac617e5d552f6bf