Bug 358925 - Icon for mount error is missleading
Summary: Icon for mount error is missleading
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.5.3
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-02 19:35 UTC by Franco Pellegrini
Modified: 2016-05-29 21:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Error on mount (38.31 KB, image/png)
2016-02-02 19:35 UTC, Franco Pellegrini
Details
Device notifier (31.30 KB, image/png)
2016-02-02 19:36 UTC, Franco Pellegrini
Details
Device Notifier and Error notification (71.03 KB, image/png)
2016-02-03 15:04 UTC, Franco Pellegrini
Details
new mounted unmounted icons (278.38 KB, image/png)
2016-05-18 20:16 UTC, andreas
Details
mount unmount icons (185.03 KB, image/png)
2016-05-20 19:06 UTC, andreas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Franco Pellegrini 2016-02-02 19:35:00 UTC
When entering a wrong password for a LUKS partition in an external link, you get an icon that looks as if the partition was mounted or everything went fine, when it was not the case.

Also the icon from the device notifier is unrelated with the action "mount".

Attaching screenshots

Reproducible: Always
Comment 1 Franco Pellegrini 2016-02-02 19:35:34 UTC
Created attachment 96983 [details]
Error on mount
Comment 2 Franco Pellegrini 2016-02-02 19:36:07 UTC
Created attachment 96984 [details]
Device notifier
Comment 3 pinheiro 2016-02-03 10:14:08 UTC
please had a screnshoot. of the issue
Comment 4 pinheiro 2016-02-03 10:29:35 UTC
(In reply to pinheiro from comment #3)
> please had a screnshoot. of the issue

just noticed you did ... the only oxygen icon i see there is the encrypted one, the others are breeze, I'm not saying this is not a valid problem in oxygen, I'm saying that you need to check if its also valid in oxygen, the problem might be the coder that assigned an incorrect icon here.

so please check against oxygen icons, if the problem is still there reopen the bug, if not reassign it to breeze
Comment 5 pinheiro 2016-02-03 10:48:56 UTC
And now i realized you might be talking about the encrypted icon. that one specifically means unopened encrypted  emblem-encrypted-locked.png if it was opened available its should be emblem-encrypted-unlocked.png, so booth icons 2 exist, your confusion if it is what I'm guessing, is related with the UI/UX that shows that "check" icon on the other side, i'm not sure that is what is going on, but if it is you need to assign this bug to the person that made this UI.
Comment 6 Franco Pellegrini 2016-02-03 15:03:41 UTC
You are correct, this is Breeze, not Oxygen.

Attaching new screenshot and reassigning after I post this comment.

I'm talking about the Icon that shows up in the notification... Unless you stop and read "Could not mount...." is not obvious that it failed... Maybe it should show a big red X or something that makes it very clear that whatever you were trying to do, it failed... (btw, this is the very same icon that is used in oxygen)

As a side note, from the device notifier menu, having that green icon is not very intuitive that it means "just mount the unit"...
Comment 7 Franco Pellegrini 2016-02-03 15:04:49 UTC
Created attachment 96994 [details]
Device Notifier and Error notification
Comment 8 andreas 2016-02-03 15:22:13 UTC
Hi this interface will get an update with some new icons. so this is a remark that the new interface has to test also with encrypted files.
Comment 9 Kai Uwe Broulik 2016-03-20 11:52:22 UTC
Note this message does *not* come from Plasma 5 but the kdelibs4 variant of Solid (KDE hardware abstraction) which doesn't find the Plasma 4 device notifier und so falls back to the popup notification.
Comment 10 andreas 2016-05-18 20:16:18 UTC
Created attachment 99057 [details]
new mounted unmounted icons

emblem-mounted is a plug
emblem-unmounted is an eject
icon would it be better?
Comment 11 Franco Pellegrini 2016-05-19 17:25:57 UTC
In my Personal opinion, it is better but still not 100% intuitive... This are my thoughts:

- The orange icon means "unmount", not "unmounted"
- I notice that the green icon is a plug, after being told it was a plug... maybe remove the connection between the pins?

What about doing something like:

- An icon like this https://upload.wikimedia.org/wikipedia/commons/thumb/5/59/Plug-in_Noun_project_4032.svg/2000px-Plug-in_Noun_project_4032.svg.png for when the device is not mounted

- The same icon but "plugged", when the device has been mounted successfully

- Just the male part of that for the "mount" action (Like the green one from your attachment, but without the union between the pins)

- An icon like the orange one in your attachment for "unmount" action


Just my 2 cents...
Comment 12 Kai Uwe Broulik 2016-05-19 19:46:56 UTC
Also, what KDE4 software are you still running? If you uninstall it, this stupid notification should not even appear. :)
Comment 13 Franco Pellegrini 2016-05-19 19:49:59 UTC
What do you mean with "stupid notification" ? it's the regular "Device notifier" that pops up when you plug in a new USB drive, etc...

I'm on Kubuntu 16.04, using Plasma 5.5.5  and QT 5.5.1

HTH
Comment 14 Kai Uwe Broulik 2016-05-19 19:55:09 UTC
https://bugsfiles.kde.org/attachment.cgi?id=96983 ← This notification
Comment 15 Kai Uwe Broulik 2016-05-19 19:55:41 UTC
Ah, right, the action in device notifier is also not obvious, sorry for the noise :)
Comment 16 Franco Pellegrini 2016-05-19 20:20:34 UTC
No problem, we are all trying to make this software better :)

Just to be clear... the notification is valid and it shows up when you try to mount an encrypted drive and you provide a wrong password...
Comment 17 andreas 2016-05-20 19:06:47 UTC
Created attachment 99105 [details]
mount unmount icons

better?
Comment 18 Kai Uwe Broulik 2016-05-20 19:35:17 UTC
Looks like a "muted" icon to me
Comment 19 Thomas Pfeiffer 2016-05-20 20:30:20 UTC
How about something like this?
http://www.iconarchive.com/show/windows-8-icons-by-icons8/Network-Disconnected-icon.html
That clearly shows that it's an unplugged plug and cannot be confused for a speaker
Comment 20 andreas 2016-05-27 12:40:35 UTC
we are talking about 8x8 px icons that's the problem!
Comment 21 andreas 2016-05-28 23:44:33 UTC
Git commit 1e4e9de420634b86acf2aaf1163d56feea872403 by andreas kainz.
Committed on 28/05/2016 at 23:43.
Pushed by andreask into branch 'master'.

update mount and unmount icon

M  +1    -1    icons-dark/emblems/8/checkmark.svg
T  +13   -1    icons-dark/emblems/8/emblem-checked.svg
M  +4    -7    icons-dark/emblems/8/emblem-mounted.svg
M  +1    -1    icons-dark/emblems/8/emblem-success.svg
M  +9    -9    icons-dark/emblems/8/emblem-unmounted.svg
M  +1    -1    icons/emblems/8/checkmark.svg
T  +13   -1    icons/emblems/8/emblem-checked.svg
M  +4    -7    icons/emblems/8/emblem-mounted.svg
M  +1    -1    icons/emblems/8/emblem-success.svg
M  +9    -9    icons/emblems/8/emblem-unmounted.svg

http://commits.kde.org/breeze-icons/1e4e9de420634b86acf2aaf1163d56feea872403
Comment 22 Franco Pellegrini 2016-05-29 21:50:57 UTC
Why is this marked as fixed? did you commit the icons from your comment #17 ? (I cannot see them from the commits.kde.org link) If so, as Kai points out, they are clearly not intuitive icons for knowing if a device is mounted or not... They are confusing