Bug 358777 - Unlock threads - currently locked to 1-n where n is cores
Summary: Unlock threads - currently locked to 1-n where n is cores
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-30 16:27 UTC by Peter
Modified: 2022-08-28 16:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
fritzibaby: Brainstorm+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter 2016-01-30 16:27:25 UTC
When rendering, you are given the option of selecting a number of Encoder threads. This is by default at 1, and can be increased up to n where n is cores.

However, the ever popular x264's default is cores * 1.5 by default. It will use this if you pass threads=0 to it.

So I believe the number of threads should be unlocked to allow a user to specify any value and I think the default behaviour should be to have it set as 0 so that the encoder will (more often than 1 is appropriate) pick a sensible number of threads to use.

Reproducible: Always
Comment 1 Davy Bartoloni 2018-05-11 11:09:18 UTC
Fixed somewhere on time.
Comment 2 Peter 2018-05-12 05:41:11 UTC
What commit fixed this?

Just tried master and the behaviour is the same, threads locked to 1-n cores where n is number of cores.
Comment 3 Davy Bartoloni 2018-05-12 07:06:26 UTC
sorry my fault.
Comment 4 farid 2020-01-11 03:21:26 UTC
(In reply to Peter from comment #2)
> What commit fixed this?
> 
> Just tried master and the behaviour is the same, threads locked to 1-n cores
> where n is number of cores.

can you pease try 19.12.1
Comment 5 Davy Bartoloni 2020-01-11 07:06:44 UTC
Just tested, on the rendering panel the Threads are limited to CPU threads (on my system these are 12) .. ussually i set this value to 0 to use all CPU capacity during rendering. (90-95 % CPU USAGE)
Comment 6 Peter 2020-01-11 19:27:45 UTC
(In reply to farid from comment #4)
> (In reply to Peter from comment #2)
> > What commit fixed this?
> > 
> > Just tried master and the behaviour is the same, threads locked to 1-n cores
> > where n is number of cores.
> 
> can you pease try 19.12.1

I would say this is fixed, now allows threads to be set from 0-n cores where n is number of cores. Mostly want to be able to set threads to 0 or omit the number of threads entirely and let the codec choose. Have had this locally patched for years, good to see it working.

I'll leave whether or not to close it to you guys as I guess the threads value hasn't been unlocked? But I'm happy with it now.
Comment 7 farid 2022-08-28 16:25:26 UTC
Closing then, thanks.