Bug 358703 - git 16.04: cannot reorder track & bin clip effects in effects stack
Summary: git 16.04: cannot reorder track & bin clip effects in effects stack
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-28 20:47 UTC by Wegwerf
Modified: 2016-05-19 15:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-01-28 20:47:31 UTC
When adding two or more effects to a track, it is not possible to change the order of effects in the effects stack. When using the effect reordering buttons "up" and "down" or trying to reorder effects using drag&drop Kdenlive shows an error along the lines of "cannot move effect".

Reproducible: Always

Steps to Reproduce:
1. Drag two effects onto the same track header. For instance, two Curves, etc.
2. Click on the track header so that the effect stack shows the effects.
3. Attempt to move either effect.

Actual Results:  
Effects cannot be moved in effect stacks of tracks, Kdenlive shows an error message in the status bar.

Expected Results:  
Effects can be moved in effect stacks not only for timeline clips or project bin clips, but also for tracks.
Comment 1 Wegwerf 2016-04-17 16:21:43 UTC
This bug is still present in current git 16.04. In addition, this bug also affects bin clip effects too. These also cannot be reordered. For some effect stacks, order is important, so not being able to reorder them is ... unfortunate. ;)
Comment 2 Jean-Baptiste Mardelle 2016-05-17 21:28:41 UTC
Git commit 24173546d73294b3bd88f8fd4551ef7ce23970d1 by Jean-Baptiste Mardelle.
Committed on 17/05/2016 at 21:28.
Pushed by mardelle into branch 'master'.

Allow reordering of bin clip effects

M  +30   -0    src/bin/bin.cpp
M  +2    -0    src/bin/bin.h
M  +23   -0    src/bin/bincommands.cpp
M  +13   -0    src/bin/bincommands.h
M  +2    -2    src/effectstack/effectstackview2.cpp
M  +2    -0    src/effectstack/effectstackview2.h
M  +1    -1    src/mainwindow.cpp
M  +27   -0    src/mltcontroller/clipcontroller.cpp
M  +6    -0    src/mltcontroller/clipcontroller.h

http://commits.kde.org/kdenlive/24173546d73294b3bd88f8fd4551ef7ce23970d1
Comment 3 Wegwerf 2016-05-19 15:25:35 UTC
Great! This also works for me. Thank you very much Jean-Baptiste for fixing this regression!