Bug 358701 - Autostart fails to edit existing entries; they remain how they were when they were first created
Summary: Autostart fails to edit existing entries; they remain how they were when they...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_autostart (show other bugs)
Version: 5.4.3
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Laurent Montel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-28 20:31 UTC by Daniel Boles
Modified: 2020-08-11 20:39 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.20


Attachments
desktop file created (and unable to edit) by autostart (101 bytes, application/x-desktop)
2016-02-01 22:26 UTC, Daniel Boles
Details
screenshot of autostart configuration and directory prior to attempting edit (184.61 KB, image/png)
2016-02-01 22:27 UTC, Daniel Boles
Details
screenshot of an edit attempt, just prior to clicking OK (28.23 KB, image/png)
2016-02-01 22:27 UTC, Daniel Boles
Details
screenshot of config and directory after attempted edit, showing no change (150.05 KB, image/png)
2016-02-01 22:30 UTC, Daniel Boles
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Boles 2016-01-28 20:31:38 UTC
Autostart fails to edit existing entries; they remain how they were when they were first created. To 'edit' an entry requires creating a new one with the desired settings and deleting the old one.

Reproducible: Always

Steps to Reproduce:
1. Open Autostart
2. Create an entry (which works)
3. Go back later and try to edit it

Actual Results:  
On saving the entry, changes are not applied: going back into it shows that the changes have not been saved, and the entry is the same as when it was first inserted.

Expected Results:  
Changes should be saved, of course!
Comment 1 Daniel Boles 2016-01-28 20:33:22 UTC
the exact test case:

entry as created: Program: xscreensaver &
desired edit: xscreensaver -no-splash &

On restarting, the splash was still shown. Opening the Autostart entry showed that the -no-splash switch had not been added. Trying to change again also failed. I had to delete the old entry and create a new one with -no-splash included. I have since replicated this with other commands.
Comment 2 Daniel Boles 2016-02-01 21:59:49 UTC
Thanks for the move. I did search for System Settings, but it wasn't found due to the space between the 2 words, which makes (its own kind of!) sense.
Comment 3 David Edmundson 2016-02-01 22:02:58 UTC
Are you adding via "add program" or "add script" ?

If adding via "add program" are you changing the entry in the "General" page or the Command entry in the Application tab?
Comment 4 Daniel Boles 2016-02-01 22:08:23 UTC
Hi David, as mentioned (somewhat cryptically) in my 2nd post, this is by Program.

And to confirm, I'm definitely attempting to edit the command proper, in the Application tab - not just the desktop shortcut name on General.

On clicking OK, the KCM pops up a message "Updating system configuration..." briefly, but it does not change the command.

Should be simple enough for someone else to test. Do you need anything else?
Comment 5 David Edmundson 2016-02-01 22:15:29 UTC
Works here with that exact example.

(running latest code)

Log doesn't show any relevant changes since 5.4.3, which you claim to have.

Can you attach some screenshots and the .desktop file from .config/autostart
Also can you run ls -l on .config/autostart and see if it's updating the timestamp at all.
Comment 6 Daniel Boles 2016-02-01 22:26:22 UTC
Created attachment 96964 [details]
desktop file created (and unable to edit) by autostart
Comment 7 Daniel Boles 2016-02-01 22:27:06 UTC
Created attachment 96965 [details]
screenshot of autostart configuration and directory prior to attempting edit
Comment 8 Daniel Boles 2016-02-01 22:27:55 UTC
Created attachment 96966 [details]
screenshot of an edit attempt, just prior to clicking OK
Comment 9 Daniel Boles 2016-02-01 22:30:10 UTC
Created attachment 96967 [details]
screenshot of config and directory after attempted edit, showing no change
Comment 10 Daniel Boles 2016-02-01 22:31:34 UTC
Thanks for the pointers, added the requested.

Notably the timestamp indicates that indeed the file has not been touched at all since the date of initial creation (or in this case, recreation since I had to delete the one without -no-splash and create this one, for obvious reasons)

Hope this helps and let me know anything else required.
Comment 11 David Edmundson 2016-02-01 22:38:05 UTC
Thanks
Comment 12 Nate Graham 2020-08-11 20:39:43 UTC
This is fixed in the rewrite which will be released in Plasma 5.20!