Bug 358687 - Impossible to add additional import include search paths on windows
Summary: Impossible to add additional import include search paths on windows
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 2.18.0 (KDE Applications 15.12.0)
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-28 16:00 UTC by Ralf Habacker
Modified: 2016-01-28 18:51 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/umbrello/95d554165e1ccdb2798b736e19b5a2500f8080f2
Version Fixed In: 2.18.2 (KDE Applications 15.12.2)

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2016-01-28 16:00:47 UTC 
Umbrello supports providing additional include pathes by specifing the environment variable UMBRELLO_INCPATH. The recent implementation uses ':' as separator between multiple pathes  regardless of the platform, which fails on windows.





Reproducible: Always

Steps to Reproduce:
1. open command shell and enter 
    set UMBRELLO_INCPATH=c:\mytestdir;c:\anotherdir
2. start umbrello
3. import some c++ header files

Actual Results:  
Umbrello adds the following pathes to the list of include dirs  'c' , '\mytestdir;c' and '\anotherdir'

Expected Results:  
umbrello should use ';' as path separator on windows.
Comment 1 Ralf Habacker 2016-01-28 16:03:42 UTC 
Git commit 95d554165e1ccdb2798b736e19b5a2500f8080f2 by Ralf Habacker.
Committed on 28/01/2016 at 16:03.
Pushed by habacker into branch 'Applications/15.12'.

Fix 'Impossible to add additional import include search pathes on windows'.
FIXED-IN:2.18.2 (KDE Applications 15.12.2)

M  +7    -1    umbrello/codeimport/import_utils.cpp

http://commits.kde.org/umbrello/95d554165e1ccdb2798b736e19b5a2500f8080f2
Comment 2 Ralf Habacker 2016-01-28 16:31:25 UTC 
Git commit 7b74efc819173ccac1f0ae6a8b6c786d4d8654bd by Ralf Habacker.
Committed on 28/01/2016 at 16:31.
Pushed by habacker into branch 'master'.

Add a note to the code import settings page how to add additional include pathes.

M  +64   -30   umbrello/dialogs/pages/codeimportoptionspage.ui

http://commits.kde.org/umbrello/7b74efc819173ccac1f0ae6a8b6c786d4d8654bd