Bug 358557 - "Online services" menu is empty
Summary: "Online services" menu is empty
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Peter Wu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-25 20:10 UTC by Gregor Mi
Modified: 2016-10-20 20:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 16.12


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Mi 2016-01-25 20:10:53 UTC
Coming from here https://bugs.kde.org/show_bug.cgi?id=312495#c10, I wonder why the Export To... > "Online services" menu is empty.
Comment 1 Antonio Rojas 2016-01-25 20:22:17 UTC
Do you have the frameworks version of kipi-plugins installed?
Comment 2 Gregor Mi 2016-01-25 21:18:28 UTC
Ah, `sudo zypper install kipi-plugins5` did the trick. Thx.

What about displaying some info about that directly in the menu if it is empty.
Comment 3 Boudhayan Gupta 2016-01-26 08:26:26 UTC
In a few months, all distributions will start shipping kf5-based kipi plugins by default. Any additional effort on this bug will be wasted.

I'm closing this as wontfix. Feel free to re-open if you have *strong* objections to this.
Comment 4 Gregor Mi 2016-01-26 18:31:57 UTC
In my experience, in decoupled systems some of the optional components tend to be missing in certain situations. So, I think a little effort to display a message (e.g. in form of a menu item) like "The list is empty, maybe kipi-plugins5 is not installed" would not be a waste of time. After all, I find this better than just showing an empty list.

If someone would provided a patch and you would care to review it, then I would reopen the bug report.
Comment 5 Boudhayan Gupta 2016-01-26 20:11:39 UTC
Sure, I'll review any patches submitted against this report. I just think it's a waste of effort because Kipi5-based plugins should start shipping by default in distros soon-ish.
Comment 6 Gregor Mi 2016-01-26 21:08:51 UTC
Ok, wanted to make sure that if I (or someone else) have some spare time to make that patch it would accepted in general. Is "resolved remind" the right status then?
Comment 7 Alexander Potashev 2016-03-27 21:24:58 UTC
I also want a message in place of empty menu. What does RESOLVED::REMIND mean?
Comment 8 Gregor Mi 2016-03-28 07:59:13 UTC
I didn't want to set it to REOPEN because of maintainer's decision to set this bug to RESOLVED::WONTFIX. I set it to RESOLVED::REMIND which means to take a look again later when a patch is provided. I just found that this status should better not to be used according to this Mozilla post: https://bugzilla.mozilla.org/show_bug.cgi?id=35839. Reason: the main status is RESOLVED and therefore it is easily missed in reports of unresolved bugs. I don't know the KDE policy for this.
Comment 9 Boudhayan Gupta 2016-03-28 10:17:55 UTC
I've now set it to VERIFIED-REMIND.

As I've said before, it's a waste of effort for me because most distros will start to ship with kf5-based plugins this cycle onwards. But if anyone has patches, I'd be happy to accept them.
Comment 10 Boudhayan Gupta 2016-04-25 21:12:39 UTC
I'm closing this now as with 16.04 distros will start shipping kf5 versions of plugins, if they haven't already.

KIPI support will be removed later anyway.
Comment 11 Gregor Mi 2016-07-09 10:03:35 UTC
Hi,

I am not sure if this is a packaging error or something else: on openSUSE 42.1, I use the latest packages from the KDE Qt5 and Frameworks5 and repositories.
When I start spectacle the Export -> Online Services menu is again empty.

I restarted spectacle from the console, looked at the output and found this:

linux-85rg:~> spectacle 
kipi.library: Plugin  "Imgur Export" has a SO version ( 31 ) which is different than libkipi ABI version ( 30 ).  Refusing to load.
kipi.library: Plugin  "SmugMug Import/Export" has a SO version ( 31 ) which is different than libkipi ABI version ( 30 ).  Refusing to load.
kipi.library: Plugin  "VKontakte.ru Exporter" has a SO version ( 31 ) which is different than libkipi ABI version ( 30 ).  Refusing to load.
etc.
Comment 12 Peter Wu 2016-10-13 00:48:28 UTC
Would the message "No KIPI plugins available" be clear enough? Or should it become "No KIPI plugins installed" (or something else)?

Proposed patch is at https://git.reviewboard.kde.org/r/129168/

@Boudhayan There is still activity in the libkipi and kipi-plugins repos, do you still want to remove it (in favor of Purpose)?
Comment 13 Peter Wu 2016-10-20 20:47:48 UTC
Git commit 47e1301926266c05976109528671192468e35b9b by Peter Wu.
Committed on 20/10/2016 at 20:42.
Pushed by peterwu into branch 'master'.

Show message if kipi-plugins are not installed

If the kipi-plugins package is not installed as dependency of kipi (Arch
Linux) or if it failed to load due to an ABI mismatch, the Share menu
would be empty.

While at it, move setting of mKipiMenuLoaded to avoid a race condition
when the menu is opened too fast.

REVIEW: 129168
FIXED-IN: 16.12

M  +5    -1    src/Gui/ExportMenu.cpp

http://commits.kde.org/spectacle/47e1301926266c05976109528671192468e35b9b