Bug 358498 - Remove weird button "Enable/disable source browse mode"
Summary: Remove weird button "Enable/disable source browse mode"
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: UI: toplevel window (show other bugs)
Version: 4.90.91
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: 5.0.0
Assignee: kdevelop-bugs-null
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2016-01-24 19:08 UTC by David Faure
Modified: 2016-04-17 16:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Faure 2016-01-24 19:08:40 UTC
I said:
> > Question: What does the button "Enable/disable source browse mode" do? Why
> > does it toggle when I press Ctrl? It's distracting :-)

Milian replied:
> Yes, I agree. It's a historical thing. It was back then introduced to show 
> that Ctrl + Click can be used for code browsing. Clicking the button with the 
> mouse "locks" this mode and normal clicks can be used for browsing. If you 
> could put that up on bko then we probably won't forget to polish this up in 
> time for 5.0 final.


Reproducible: Always
Comment 1 Kevin Funk 2016-01-25 09:32:56 UTC
Git commit aeb3a26837fe1510bbb5f49fffaad8d560498f65 by Kevin Funk.
Committed on 25/01/2016 at 09:32.
Pushed by kfunk into branch '5.0'.

Remove confusing button in contextbrowser

Remove "Enable/disable source browse mode" button
FIXED-IN: 5.0.0

M  +7    -24   plugins/contextbrowser/browsemanager.cpp
M  +0    -4    plugins/contextbrowser/browsemanager.h
M  +0    -16   plugins/contextbrowser/contextbrowser.cpp
M  +0    -2    plugins/contextbrowser/contextbrowser.h

http://commits.kde.org/kdevplatform/aeb3a26837fe1510bbb5f49fffaad8d560498f65
Comment 2 Igor Kushnir 2016-04-17 16:05:01 UTC
Since the Source Browse Mode can actually be useful for quick code navigation, I added it back as a checkable menu action.

See for example: http://code.woboq.org/qt5/qtbase/src/plugins/platforms/xcb/qxcbclipboard.cpp.html#445
This online code browser is permanently in "sort of" Source Browse Mode.

The menu action shouldn't be distracting or confusing at all.
Review requests:
https://git.reviewboard.kde.org/r/127669/
https://git.reviewboard.kde.org/r/127670/