Bug 358494 - KDevelop/KatePart/KTextEditor should always ensure that the file ends with a newline
Summary: KDevelop/KatePart/KTextEditor should always ensure that the file ends with a ...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-ktexteditor
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-24 18:37 UTC by David Faure
Modified: 2016-01-31 21:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Faure 2016-01-24 18:37:46 UTC 
I tried kdevelop-kf5 and gcc told me:

faviconscache.cpp:107:2: warning: no newline at end of file [-Wnewline-eof]

I think it's the IDE's job to ensure the file always ends with a newline.
A few hours later, I discovered a checkbox in the kdevelop settings. Well, I think it should be on by default.

Reproducible: Always
Comment 1 Christoph Cullmann 2016-01-31 21:15:44 UTC 
Done, Kevin already changed the default, now the key is altered to enforce that the default will be in action for the next frameworks release.

https://phabricator.kde.org/rKTEXTEDITOR54536d9cc9da