At the moment I cannot use the new monitor-integrated audio levels, because I have no clue what concrete levels they show. In particular, which dB levels are considered to be "yellow" and "red". Also, it's unclear where concrete levels, such as the often-used -10dB is. For instance, the LED level meter of my behringer USB preamp/mixer has its LEDs marked with dB levels. I would expect for the level indicator being more than merely some coarse indicator to have clear dB markings. For instance, see attached Audacity screenshot of horizontal dB meters. Reproducible: Always
Created attachment 96798 [details] example of Audacity db meter showing metering marks
Git commit 16b00e2d27ed516bac4044cdce8c1072806eca36 by Jean-Baptiste Mardelle. Committed on 25/01/2016 at 01:11. Pushed by mardelle into branch 'master'. Improved audio monitoring M +2 -12 src/monitor/glwidget.cpp M +55 -47 src/monitor/monitoraudiolevel.cpp http://commits.kde.org/kdenlive/16b00e2d27ed516bac4044cdce8c1072806eca36
Jean-Baptiste, this is a great improvement! Now I can retire the separate audio pane and get some screen space back into my track pane. One thing I notice seems odd and I think it is a bug: the signal bars never go below approx. -22dB. If this were really the case, my audio would sound terrible. Even for regions where there is no audio at all, the meter still shows -22dB. Another minor issue are the particular level marks: -2, -4, -7, -9, -13 seem arbitrary and slightly odd. I would expect at least the prominent -10, maybe with -5 and -15 around it between. The -10dB level is a level so much used when preparing audio. The -2dB mark is fine as it marks the beginning of the yellow range.
Git commit e464dbb2bd036a059d701fb0b2d6f558a7f973dc by Jean-Baptiste Mardelle. Committed on 25/01/2016 at 19:28. Pushed by mardelle into branch 'master'. Fix no audio interpreted as 20dB M +8 -2 src/monitor/glwidget.cpp M +5 -0 src/monitor/sharedframe.cpp M +2 -1 src/monitor/sharedframe.h http://commits.kde.org/kdenlive/e464dbb2bd036a059d701fb0b2d6f558a7f973dc
Git commit 32b22eef65735bc9d5bbaa77ecd02204e4a1e03c by Jean-Baptiste Mardelle. Committed on 25/01/2016 at 19:37. Pushed by mardelle into branch 'master'. Cleaner dB scale for audio monitor M +1 -1 src/monitor/monitoraudiolevel.cpp http://commits.kde.org/kdenlive/32b22eef65735bc9d5bbaa77ecd02204e4a1e03c
It seems like I'm writing the same bugs about these exact issues. Maybe I should just comment in this one. :) Levels indicator is looking good, though!
Jesse, it's good to see that different people come up with the same bugs.
Should be fixed now with recent change in MLT's git master
I've pulled the recent MLT git master as well as Kdenlive git master, recompiled everything, and installed. Now the audio meter in the project monitor doesn't work at all: it's completely stuck at -20db. It doesn't move at all, even if there is proper audio.
Git commit 67e3f6057ebf01a3aefe7b381a6442f5fd40207e by Jean-Baptiste Mardelle. Committed on 26/01/2016 at 08:30. Pushed by mardelle into branch 'master'. Fix audio level on locale with comma M +4 -2 src/monitor/glwidget.cpp http://commits.kde.org/kdenlive/67e3f6057ebf01a3aefe7b381a6442f5fd40207e
Works now. Thank you very much Jean-Baptiste for this lightning fast fix!
One really minor thing: when there is no audio data at all, then the meter shows -20dB. As soon as there is audio data, the new low dB values kick in. Could this be the "old" -20dB (-1000?) default in the Kdenlive meter display?
(rant on: why do people worry about metric versus inches, when we can have commas versus dots over here :D /rant off)
The -20dB on no audio data should have been fixed by one of yesterday's commit I made yesterday. I cannot reproduce it anymore. Do you still have the problem with current git ?
Jean-Baptiste, I'm on recent git and can still reproduce the issue: it happening around the last few seconds of a wav file. I checked this region with Audacity to be sure, and the wav in this section definitely has less than -60dB signal. The audio meter however shows the "famous" around -20dB. In fact, when I repeatedly play only this silent section the peak indicators glide down to around -20dB, then settle there. They are not definitely going down to -60dB or so. However, most of the time, the meter correctly goes down to -60dB and less for silence. It's only in some cases that the meter instead locks onto -20dB
JB, I can confirm this issue as well, running the latest Kdenlive-git master build. See this video for an example (uploaded to YT two minutes ago): https://youtu.be/yH6X0BUgKXA.
Git commit 723a8b8fa9d8c0c0c8cfebd2b7cbe027a2d071d4 by Jean-Baptiste Mardelle. Committed on 27/01/2016 at 00:13. Pushed by mardelle into branch 'master'. Refactor new audio levels, should fix most problems. M +1 -1 src/audiospectrum/audiographspectrum.h M +1 -2 src/monitor/CMakeLists.txt M +6 -73 src/monitor/glwidget.cpp M +2 -5 src/monitor/glwidget.h M +18 -10 src/monitor/monitor.cpp M +3 -7 src/monitor/monitor.h A +6 -0 src/monitor/scopes/CMakeLists.txt A +162 -0 src/monitor/scopes/dataqueue.h [License: GPL (v3+)] A +201 -0 src/monitor/scopes/monitoraudiolevel.cpp [License: GPL] A +60 -0 src/monitor/scopes/monitoraudiolevel.h [License: GPL] A +95 -0 src/monitor/scopes/scopewidget.cpp [License: GPL (v3+)] A +129 -0 src/monitor/scopes/scopewidget.h [License: GPL (v3+)] A +209 -0 src/monitor/scopes/sharedframe.cpp [License: GPL (v3+)] A +77 -0 src/monitor/scopes/sharedframe.h [License: GPL (v3+)] M +1 -2 src/renderer.cpp http://commits.kde.org/kdenlive/723a8b8fa9d8c0c0c8cfebd2b7cbe027a2d071d4
Jean-Baptiste, this now looks fine. I've pulled your fixes this morning and them hammered on Kdenlive while I was editing a voice over into my recent project, a lot of cuts. I didn't notices any -20dB stuck levels, instead, everything worked as intended. Thank you very much for fixing this. The integrated audio meter is incredibly useful as it smoothly fits into the monitors, making good use of the available screen space.
I can confirm. Everything works great!
This has been successfully fixed and works great. Thank you, Jean-Baptiste, again for the new monitor-integrated audio meter: that's a great little enhancement!