Bug 358365 - Complete refactoring of line color and line with based setting to QPen.
Summary: Complete refactoring of line color and line with based setting to QPen.
Status: REPORTED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-22 10:16 UTC by Ralf Habacker
Modified: 2016-01-22 10:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2016-01-22 10:16:04 UTC
From the umbrello-soc branch a new QPen based design to access (an set) line color and line with for a widget (class AssociationLine and Symbol). It would be nice to use this api in the whole umbrello source code.





Reproducible: Always
Comment 1 Ralf Habacker 2016-01-22 10:33:12 UTC
Git commit c14b580a5f42358d9dfbd916b3afc315e12ffd51 by Ralf Habacker.
Committed on 22/01/2016 at 10:32.
Pushed by habacker into branch 'Applications/15.12'.

Fix 'No change of association symbol line colour and width possible'.

The bug is caused by two issues:

1. line color changes are not routed through the virtual method setLineColor()
2. class AssociationLine did not propagate line color changes to the related symbols.

This patch includes a minor refactoring in class AssociationLine
to provide the standard pen based api, which is required to set symbol pen.
Related: bug 358358
FIXED-IN:2.18.2 (KDE Applications 15.12.2)

M  +23   -8    umbrello/umlwidgets/associationline.cpp
M  +2    -0    umbrello/umlwidgets/associationline.h
M  +16   -0    umbrello/umlwidgets/associationwidget.cpp
M  +2    -0    umbrello/umlwidgets/associationwidget.h
M  +1    -1    umbrello/umlwidgets/boxwidget.cpp
M  +8    -8    umbrello/umlwidgets/widgetbase.cpp

http://commits.kde.org/umbrello/c14b580a5f42358d9dfbd916b3afc315e12ffd51