Bug 358315 - Typo in .desktop file leads to KRunner freeze
Summary: Typo in .desktop file leads to KRunner freeze
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: 25.1.0
Assignee: Guillaume DE BURE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-21 16:03 UTC by Alexey Chernov
Modified: 2016-01-29 09:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch fixing the typo and certain problem. (657 bytes, patch)
2016-01-21 16:04 UTC, Alexey Chernov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Chernov 2016-01-21 16:03:22 UTC
A small typo in D-Bus service address of Skrooge occasionally makes KRunner frozen during the whole Skrooge lifetime after startup (if choose application item, with icon, in KRunner rather than "Execute Skrooge" item) and "KDEInit couldn't launch <path-to-scrooge>" error message.
The patch is applied, but it's really the simplest one.

Reproducible: Always

Steps to Reproduce:
1. Open KRunner.
2. Type "skrooge".
3. Choose the "Skrooge" item (usually the first one).

Actual Results:  
Notice that KRunner keeps showing and doesn't process any user input as if it prepares to crash. Close Skrooge to see that it's still functioning but was frozen, notice the error message.
Comment 1 Alexey Chernov 2016-01-21 16:04:22 UTC
Created attachment 96768 [details]
Patch fixing the typo and certain problem.
Comment 2 Stephane MANKOWSKI 2016-01-21 20:23:31 UTC
Git commit 50030e6d606c0608314f905ddb022c9f7a2756d2 by Stephane Mankowski.
Committed on 21/01/2016 at 20:06.
Pushed by smankowski into branch 'master'.

Typo in .desktop file leads to KRunner freeze

M  +1    -0    CHANGELOG
M  +1    -1    skrooge/org.kde.skrooge.desktop

http://commits.kde.org/skrooge/50030e6d606c0608314f905ddb022c9f7a2756d2
Comment 3 Alexey Chernov 2016-01-21 20:45:50 UTC
Thank you very much for merging it!
Comment 4 Adrian Piotrowicz 2016-01-29 08:09:46 UTC
Changing desktop file didn't work for me.
Comment 5 Alexey Chernov 2016-01-29 08:17:44 UTC
(In reply to Adrian Piotrowicz from comment #4)
> Changing desktop file didn't work for me.

It could also be that some other version is caught up in KRunner. In this case cleaning up ~/.local/share/applications worked for me (but be sure you don't have anything useful there, back it up beforehand).
Comment 6 Stephane MANKOWSKI 2016-01-29 08:34:47 UTC
This fix is needed too:
https://quickgit.kde.org/?p=skrooge.git&a=commit&h=54527cdff004875bae03fd28433f4df15c9d1988
Comment 7 Adrian Piotrowicz 2016-01-29 09:07:25 UTC
Thanks Stephane, now it's working like a charm.