Bug 358282 - Usability: replace (un)expand icon button with "Show/hide details" link button
Summary: Usability: replace (un)expand icon button with "Show/hide details" link button
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.5.3
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-20 22:09 UTC by Gregor Mi
Modified: 2016-01-21 00:35 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.5.4
mklapetek: VisualDesign+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Mi 2016-01-20 22:09:53 UTC
Currently, for the Move/copy files notification: the unexpand button looks like stop.

Details and screenshots see here: https://forum.kde.org/viewtopic.php?f=285&t=130623
Comment 1 Martin Klapetek 2016-01-20 22:55:48 UTC
Thanks for the report

Yes the icons looks weird, it's mostly a remnant from kde4 times
when the icon "list-remove" was a minus sign. Now it's a stop sign
for whatever reason.

Looking over all the "actions" icon, I did not however find an icon
pair for "expand/collapse". The best one I could find is "arrow-down"
and "arrow-up", but that doesn't feel right, especially since it can
change into actual arrow at any point and just look weird.

VDG, what's your recommendation for an icon here?
Comment 2 Martin Klapetek 2016-01-20 23:02:00 UTC
Or maybe the button should go away altogether and it should
be clickable in the same way as device notifier and network
manager applets' lists are? Ie. no button but the whole list item
is clickable and it expands on clicking.
Comment 3 Thomas Pfeiffer 2016-01-20 23:45:46 UTC
Arrow-right and arrow-down are used for expandable list items, so reusing it here does sound very sensible to me.
Why would we introduce a new icon for the same thing?
Comment 4 Martin Klapetek 2016-01-21 00:35:23 UTC
Git commit 994de033983c32fca24f09465cf9b98b3e28f568 by Martin Klapetek.
Committed on 21/01/2016 at 00:32.
Pushed by mklapetek into branch 'Plasma/5.5'.

[notifications] Replace the icon on the button to expand the running job

Use arrows instead.
FIXED-IN: 5.5.4

M  +1    -1    applets/notifications/package/contents/ui/JobDelegate.qml

http://commits.kde.org/plasma-workspace/994de033983c32fca24f09465cf9b98b3e28f568
Comment 5 Martin Klapetek 2016-01-21 00:35:35 UTC
Git commit d6baf450d3ff4cf87461f0b32eef73d12298cb0a by Martin Klapetek.
Committed on 21/01/2016 at 00:34.
Pushed by mklapetek into branch 'master'.

[notifications] Add a button tooltip to the expanding button

New string, master only.

M  +2    -0    applets/notifications/package/contents/ui/JobDelegate.qml

http://commits.kde.org/plasma-workspace/d6baf450d3ff4cf87461f0b32eef73d12298cb0a