Bug 358272 - No color change for communication diagram messages possible
Summary: No color change for communication diagram messages possible
Status: REPORTED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 2.18.0 (KDE Applications 15.12.0)
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-20 18:55 UTC by Ralf Habacker
Modified: 2021-03-09 07:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2016-01-20 18:55:07 UTC
For communication diagram messages there is a context menu entry to change the line color, but a changed color is not applied to the message.

Reproducible: Always

Steps to Reproduce:
1. start umbrello
2. add a communication diagram
3. add two objects and a message
4. Select message and right click on 'line color' to change the color
5. enter a different color
6. press ok 


Actual Results:  
The color of the message does not change.


Expected Results:  
The color should be applied to the message widget.
Comment 1 Ralf Habacker 2016-01-20 19:05:31 UTC
It turns out that the implementation  sets up the line color of the AssociationWidget's class member m_nameWidget, which is never used.

void AssociationWidget::slotMenuSelection(QAction* action)
{
....
    // if it's a collaboration message we now just use the code in floatingtextwidget
    // this means there's some redundant code below but that's better than duplicated code
    if (isCollaboration() && sel != ListPopupMenu::mt_Delete) {
        m_nameWidget->slotMenuSelection(action);
        return;
    }
Comment 2 Justin Zobel 2021-03-09 07:00:38 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.