Bug 358167 - Automatically deduce plasmoid icon from folder
Summary: Automatically deduce plasmoid icon from folder
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop icons & Folder View widget (show other bugs)
Version: master
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-18 14:36 UTC by Kai Uwe Broulik
Modified: 2016-01-18 22:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2016-01-18 14:36:58 UTC
When creating a FolderView by dropping a folder somewhere, the resulting plasmoid should automatically deduce its icon from the folder. This can be observed by dropping a folder with a custom icon onto a panel and chosing "Folder".

Reproducible: Always

Steps to Reproduce:
1. Create a new folder and give it a custom icon
2. Drop it onto your panel
3. Choose "Create Folder"

Actual Results:  
A new FolderView widget appears with the default folder icon

Expected Results:  
A new FolderView widget appears with the icon of the folder

I think if no custom icon has been set, changing the URL of the FolderView in settings should also do update the icon.
Comment 1 Eike Hein 2016-01-18 22:05:57 UTC
Git commit c8d1de8e2009c63093ec2c91267a0a92f1c0efea by Eike Hein.
Committed on 18/01/2016 at 22:04.
Pushed by hein into branch 'master'.

Use live directory icon by default for compact repr instead of hard-coding "folder".

Custom icon can still be set via config dialog.

M  +3    -0    containments/desktop/package/contents/config/main.xml
M  +7    -2    containments/desktop/package/contents/ui/ConfigIcons.qml
M  +1    -1    containments/desktop/package/contents/ui/main.qml
M  +26   -0    containments/desktop/plugins/folder/foldermodel.cpp
M  +6    -0    containments/desktop/plugins/folder/foldermodel.h

http://commits.kde.org/plasma-desktop/c8d1de8e2009c63093ec2c91267a0a92f1c0efea