Bug 358094 - Regression; Scroll-zoom with touchpads broken in Marble v15.12
Summary: Regression; Scroll-zoom with touchpads broken in Marble v15.12
Status: RESOLVED WORKSFORME
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.13 (KDE Applications 15.12)
Platform: Compiled Sources Linux
: NOR major
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-16 21:01 UTC by Stefan Bauer
Modified: 2022-11-23 05:16 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Height Depending on Number of mouse scrolls (257 bytes, text/csv)
2016-02-28 10:38 UTC, Stefan Bauer
Details
Graph showing height depending on mouse scrolls (22.16 KB, image/png)
2016-02-28 10:39 UTC, Stefan Bauer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Bauer 2016-01-16 21:01:17 UTC
Since the upgrade to v15.12 I noticed in Marble-KDE that zooming via mouse-scroll is very jumpy and unpredictable. Instead of zooming in, the view jumps around, zooms in the wrong direction etc.

I'm currently bisecting the issue. 15.08 was fine in this regard.

Reproducible: Always

Steps to Reproduce:
1. Start the Marble KDE application.
2. Use the mouse wheel / touch pad to zoom in / out
3.

Actual Results:  
Jumps around

Expected Results:  
Zooms into the location I'm pointing at.
Comment 1 Dennis Nienhüser 2016-01-17 09:04:48 UTC
Can you please check if https://quickgit.kde.org/?p=marble.git&a=commit&h=1b4da07 causes the problem?
Comment 2 Stefan Bauer 2016-01-17 10:37:30 UTC
(In reply to Dennis Nienhüser from comment #1)
> Can you please check if
> https://quickgit.kde.org/?p=marble.git&a=commit&h=1b4da07 causes the problem?

You nailed it, this commit introduces the problem.

While testing I identified some prerequisites that have to be met in order to trigger the issue:
- Touchpad is used (X.org synaptics in my case). Using a mouse with indexed scroll wheel does not trigger the problem.
- Only certain maps trigger the issue: OpenCycleMap, Plain Map, Satellite View and some more work, OSM Hike&Bike Map and OpenStreetMap don't. I guess this is related to whether these maps are "discrete" or not.
Comment 3 Stefan Bauer 2016-02-28 09:31:52 UTC
For completeness, the link to the related code review:

https://git.reviewboard.kde.org/r/124834/

Added reviewers and committer of the breaking change to the CC list.
Comment 4 Stefan Bauer 2016-02-28 10:37:33 UTC
I did some more investigations and would like to share my findings.

First:
I was debugging MarbleDefaultInputHandler::handleWheel() using a mouse and touchpad. I see a difference in the wheelevt.delta() value: With the mouse, on scroll "click" results in single a value of exactly +/- 120. With the touchpad, I get a series of values like 15 15 15 12 8 12 11 8 3 25 11 4. As this values gets integer-divided first by 3 and then by 5 for discrete maps, I'm expecting trouble for lower values of wheelevt.delta().

Second:
Using a mouse, I was comparing the height in kilometers of a "discrete" and a non-discrete map depending on how often I scroll into the globe. I see severe inconsistencies here, resulting in a different user experience depending on whether the map is discrete or not. See the attached files for the data.

Do you agree that these values should be identical for both map-types or am I missing something?
Comment 5 Stefan Bauer 2016-02-28 10:38:38 UTC
Created attachment 97587 [details]
Height Depending on Number of mouse scrolls
Comment 6 Stefan Bauer 2016-02-28 10:39:17 UTC
Created attachment 97588 [details]
Graph showing height depending on mouse scrolls
Comment 7 Denis Kurz 2016-05-19 20:39:40 UTC
I confirm this bug for version 16.04.1.
Comment 8 Andrej Dundovic 2016-08-09 20:08:04 UTC
Also confirm.
- Marble ver. 1.14.1
- KDE Frameworks 5.24.0
- Qt 5.6.1 (built against 5.6.1)
- The xcb windowing system
Comment 9 Dennis Nienhüser 2016-08-09 20:13:13 UTC
Should be fixed with KDE Applications 16.08 (Marble 2.0). See https://phabricator.kde.org/D1585
Comment 10 Andrej Dundovic 2016-09-19 19:34:04 UTC
I can confirm it is fixed.
Comment 11 Justin Zobel 2022-10-24 00:46:57 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 12 Bug Janitor Service 2022-11-08 05:10:05 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 13 Bug Janitor Service 2022-11-23 05:16:31 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!