Bug 357938 - offer to create openconnect-VPN without required packages installed
Summary: offer to create openconnect-VPN without required packages installed
Status: RESOLVED FIXED
Alias: None
Product: plasma-nm
Classification: Plasma
Component: general (show other bugs)
Version: 0.9.3.3
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Lukáš Tinkl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-13 17:36 UTC by c.buhtz
Modified: 2016-01-17 13:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
muonscreenshot with packages (65.70 KB, image/jpeg)
2016-01-13 17:37 UTC, c.buhtz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description c.buhtz 2016-01-13 17:36:30 UTC
(I am not sure if I selected with "plasma-nm" the correct KDE component for that bugreport. Please correct.)

It is possible to create a openconnect-VPN connection entry in the NetworkManager (GUI) when only the "libopenconnect2"-package is installed.
"network-manager-openconnect*" is not need nor the NetworkManager ask for this.

But (of course!) when I click on "connect" nothing happen -- not even a error message.

The NM should check for the correct packages/components. If they are not pressent a openconnect-connection shouldn't be offered to the user.

Reproducible: Didn't try
Comment 1 c.buhtz 2016-01-13 17:37:28 UTC
Created attachment 96623 [details]
muonscreenshot with packages
Comment 2 Jan Grulich 2016-01-14 07:48:58 UTC
I'm not sure whether there is a way how to check that such NM VPN plugin is installed. This could be solved on packaging level (like we do in Fedora). Basically each plasma-nm VPN plugin is moved to a subpackage with dependency on required NM VPN plugin and when this NM VPN plugin is removed, then also the plasma-nm subpackage is removed and then not offered in plasma-nm connection editor.

Closing this bug as there is probably nothing what we can do.
Comment 3 c.buhtz 2016-01-14 21:18:20 UTC
Thanks for your fast reply. btw: I can reproduce that problem on a fresh 14.04 Kubuntu.
I understand your technical descriptions of the problem.

I think you make it to easy for you.

1. The NetworkManager should check for the correct components (don't mean the packages here!). Currently it offers a openconnect-VPN without having the complete components for that. It is a bug indpenend from the package system.

2. As the creator/maintainer of NM your are responsible for the package maintainers to all different distributions and for the communication with them. If you see the problem in the packaging system you have to communicate that to the specific maintainer. For me as a simple user it is nearly impossible to see and understand the complexe personal structures between the developers and distribution specific package maintainers.

So leave this bug report open because the bug is still theire. Please point here to related bug reports if you open a bug report about the package problem you described.
Comment 4 Jan Grulich 2016-01-15 09:04:03 UTC
At first, in recent plasma-nm versions you will be notified about missing NetworkManager VPN plugin once you try to activate a VPN connection with missing plugin.

I don't make this easy for me, there is a difference between plasma-nm VPN plugin and NetworkManager VPN plugin. For creating VPN connections in plasma-nm connection editor you need just plasma-nm VPN plugins (because there is no interaction with NM), however for their activation you need NetworkManager VPN plugin. We do check just for plasma-nm VPN plugins in the editor, which is easy. I guess there is definitely some way how to check for NetworkManager VPN plugins using NM libraries, but I haven't had time to investigate that. On the other hand, if we would check also for NM VPN plugin then users might not find out what they are missing if they are not able to edit/create VPN connections. Now all our VPN plugins are installed independently and once it comes to interaction with NetworkManger then they will be informed with notification about missing NetworkManager VPN plugin.
Comment 5 c.buhtz 2016-01-15 10:10:15 UTC
>  I haven't had time to investigate that
That is ok. But don't close the bug because of less ressources. Just forumlate a conrete TODO-item and leave the bug report open until someone has time for that.

> once it comes to interaction with NetworkManger then they
> will be informed with notification about missing NetworkManager VPN plugin.

As I described in my original bug report this is not true. There is no message no error nothing.
When you click on "Connect" the button moves but nothing happens. No error, no message, nothing!

Please check it out. Reproduce: Use a fresh Kubuntu 14.04.3. Create a openconnect-VPN connection and click on "connect".
Comment 6 Jan Grulich 2016-01-15 11:58:16 UTC
Kubuntu 14.03.3 is almost 2 years old, you should really try newer version.
Comment 7 c.buhtz 2016-01-15 12:49:54 UTC
Kbuntu is an LTS, so it is relevant for KDE.
I can check the next LTS for you if it is available.
Comment 8 Jan Grulich 2016-01-15 13:09:23 UTC
It may be relevant, but only for security and important fixes, not new releases introducing features and major changes. Your reported version is 0.9.3.3, which is pretty damn old and even KDE 4 version is no longer maintained because we are now focused to Plasma 5.
Comment 9 c.buhtz 2016-01-16 09:10:40 UTC
We are writing not the same language?! :D

The version doesn't matter for the formaly existence of this bug!
Me as a user I reported a bug in an "old" version.

Now someone need to know or check if this problem is reproducable in the current "newest" version, too. If not: Report that and close the bug-report.

You can not ignore a bug only because it is reported for on old version. You have to check if it exist in the new one or not.

It is easy, isn't it?
Comment 10 Jan Grulich 2016-01-17 10:03:22 UTC
I don't ignore anything, this bug is already solved in one of newer versions. Really, if you want to have this bug fixed then use newer version of Kubuntu.
Comment 11 Jan Grulich 2016-01-17 10:04:56 UTC
I mean the problem with missing notification is solved in newer versions, but you should still be able to create all VPN connections even with missing NM plugins, which I don't consider as a problem.
Comment 12 c.buhtz 2016-01-17 13:41:54 UTC
> is solved in newer versions

Great, that is what I wanted to hear and what this and any other bug report is all about. So this missunderstanding was a communication problem. ;)

It is not a securtiy bug so there is no need to fix it in an old version. This wasn't my intention, too!
I just wanted to report it.

btw: How you handled this bug report wasn't end-user-friendly. (And it wasn't the first time I was treated like that here at KDE.) I am a developer, too. But here I am a user. You want mumy, daddy and granny using free software and participate to the projects? Then please be more open minded and take care of granny when answering your next bug report and communicating with a user.

The bug is fixed. This is nice and closed.