Bug 357880 - Update G'Mic Filter to latest from Github (right mouse button no longer needed in interactive mode)
Summary: Update G'Mic Filter to latest from Github (right mouse button no longer neede...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (other bugs)
Version First Reported In: 2.9.10
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-12 10:17 UTC by Carsten Nikiel
Modified: 2016-01-30 17:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Nikiel 2016-01-12 10:17:22 UTC
I asked the G'Mic developers to find a way to not use the right mouse button in the colorize interactive filter for G'Mic. (A Surface Pro Pen has no right mouse button)
He was very fast and comitted the update to GIT already.
Now it is possible to use X for erasing a control point and P for color selecting.
This way there is no right mouse button needed anymore.

It would be nice to get this in the G'Mic filter for Krita directly.

Reproducible: Always

Steps to Reproduce:
1. Try to remove a control point without a right mouse button in the colorize interactive filter for G'Mic
Comment 1 Halla Rempt 2016-01-23 08:09:25 UTC
Hi,

I'm afraid we will have to wait for that code to enter an official g'mic release before it can be integrated with Krita. Do you know when David Tschumperle plans to release a version with this fix?
Comment 2 David Tschumperlé 2016-01-23 09:33:26 UTC
I'm working on the implementation of a last (cool:)) new feature for G'MIC 1.6.9, then I'll release it, maybe in two or three weeks.
Comment 3 Halla Rempt 2016-01-23 09:39:09 UTC
Cool, thanks! And then we can see if gmic works with msvc 2015 :-)
Comment 4 David Tschumperlé 2016-01-23 09:53:31 UTC
I'll try at least to compile it with msvc2012 (the one I have at the lab).
Anyway, I doubt there will be an improvement compared to previous versions of G'MIC. I think you should consider using the .dll bridge done by Tobias Fleischer (https://plus.google.com/b/117441237982283011318/+TobiasFleischer/posts?cfem=1) to make the plug-ins for Natron, Nuke, and After Effects.
You shouldn't have to worry anymore about compiling the G'MIC library by yourself.
Comment 5 Halla Rempt 2016-01-23 09:54:57 UTC
Do you have a direct link to the source code?
Comment 6 David Tschumperlé 2016-01-23 10:12:52 UTC
No, But I've sent you a mail so you can contact Tobias directly.
Comment 7 Halla Rempt 2016-01-24 15:23:20 UTC
Thanks! I will pick up on this tomorrow.

WISHGROUP: Small Usability Fixes
Comment 8 David Tschumperlé 2016-01-27 10:15:13 UTC
Today, I've released a 'pre-version' of G'MIC, which should be very close to the final release. I'm still trying to find bugs (if any remaining :) ). Maybe it could be a good candidate to test on your own.
So far, I've compiled it successfully with MSVC 2012. I've made it generate a synthetic image as well.
As I forgot to enable the display support on Windows, I'm recompiling it right now (takes approx. 45mn here), I'll do some tests with the interactive windows then.
Anyway, all look good so far :)
Comment 9 David Tschumperlé 2016-01-27 10:16:11 UTC
(In reply to David Tschumperlé from comment #8)
> Today, I've released a 'pre-version' of G'MIC, which should be very close to
> the final release. I'm still trying to find bugs (if any remaining :) ).
> Maybe it could be a good candidate to test on your own.
> So far, I've compiled it successfully with MSVC 2012. I've made it generate
> a synthetic image as well.
> As I forgot to enable the display support on Windows, I'm recompiling it
> right now (takes approx. 45mn here), I'll do some tests with the interactive
> windows then.
> Anyway, all look good so far :)

And I forgot to give the link where you can download the today's pre-version :

http://gmic.eu/files/prerelease/
Comment 10 Halla Rempt 2016-01-27 10:34:46 UTC
Okay, I'll make a build as soon as I've got cpu cycles to spare on my build vm :-)
Comment 11 Halla Rempt 2016-01-30 14:16:35 UTC
Git commit e53f5f454fa238510e2626b771a8ef6b2d9deb23 by Boudewijn Rempt.
Committed on 30/01/2016 at 14:15.
Pushed by rempt into branch 'master'.

Update g'mic to 1.6.9-pre

M  +10960 -5306 plugins/extensions/gmic/3rdparty/gmic/CImg.h
A  +49226 -0    plugins/extensions/gmic/3rdparty/gmic/gimp_update169.gmic
M  +4938 -4262 plugins/extensions/gmic/3rdparty/gmic/gmic.cpp
M  +215  -194  plugins/extensions/gmic/3rdparty/gmic/gmic.h
M  +3    -1    plugins/extensions/gmic/CMakeLists.txt
M  +2    -0    plugins/extensions/gmic/Category.h
M  +2    -1    plugins/extensions/gmic/Command.cpp
M  +1    -0    plugins/extensions/gmic/Command.h
C  +6    -37   plugins/extensions/gmic/Component.cpp [from: plugins/extensions/gmic/Component.h - 050% similarity]
M  +6    -5    plugins/extensions/gmic/Component.h
M  +3    -1    plugins/extensions/gmic/kis_gmic_blacklister.h
M  +20   -28   plugins/extensions/gmic/kis_gmic_filter_model.cpp
M  +5    -4    plugins/extensions/gmic/kis_gmic_filter_model.h
M  +0    -1    plugins/extensions/gmic/kis_gmic_updater.cpp
M  +5    -14   plugins/extensions/gmic/kis_gmic_widget.cpp

http://commits.kde.org/krita/e53f5f454fa238510e2626b771a8ef6b2d9deb23
Comment 12 David Tschumperlé 2016-01-30 14:22:05 UTC
So, it seems to work ? Final release of 1.6.9 is planed for next week :)
Thanks for your time Boud.
Comment 13 Halla Rempt 2016-01-30 14:24:32 UTC
Git commit ae72033ae50e9d4f56030e9ee5d5ee5ae759fea2 by Boudewijn Rempt.
Committed on 30/01/2016 at 14:24.
Pushed by rempt into branch 'calligra/2.9'.

Update to G'Mici 1.6.9-pre

M  +10960 -5306 krita/plugins/extensions/gmic/3rdparty/gmic/CImg.h
A  +49226 -0    krita/plugins/extensions/gmic/3rdparty/gmic/gimp_update169.gmic
M  +4938 -4262 krita/plugins/extensions/gmic/3rdparty/gmic/gmic.cpp
M  +215  -194  krita/plugins/extensions/gmic/3rdparty/gmic/gmic.h
A  +45682 -0    krita/plugins/extensions/gmic/3rdparty/gmic/gmic_stdlib.h     [License: GENERATED FILE]  *
M  +3    -1    krita/plugins/extensions/gmic/CMakeLists.txt
M  +2    -0    krita/plugins/extensions/gmic/Category.h
M  +2    -1    krita/plugins/extensions/gmic/Command.cpp
M  +1    -0    krita/plugins/extensions/gmic/Command.h
C  +6    -37   krita/plugins/extensions/gmic/Component.cpp [from: krita/plugins/extensions/gmic/Component.h - 050% similarity]
M  +6    -5    krita/plugins/extensions/gmic/Component.h
M  +3    -1    krita/plugins/extensions/gmic/kis_gmic_blacklister.h
M  +20   -28   krita/plugins/extensions/gmic/kis_gmic_filter_model.cpp
M  +5    -4    krita/plugins/extensions/gmic/kis_gmic_filter_model.h
M  +0    -1    krita/plugins/extensions/gmic/kis_gmic_updater.cpp
M  +5    -14   krita/plugins/extensions/gmic/kis_gmic_widget.cpp

The files marked with a * at the end have a non valid license. Please read: http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


http://commits.kde.org/calligra/ae72033ae50e9d4f56030e9ee5d5ee5ae759fea2
Comment 14 Halla Rempt 2016-01-30 14:41:31 UTC
On Linux, yes -- I'm now doing a Windows build. I did contact Tobias, but he hasn't shared his mingw dll with me yet -- guess he's just as overloaded as I am :-)
Comment 15 Halla Rempt 2016-01-30 17:56:38 UTC
Everything built... But mscv2015 still doesn't build a working gmic, so I still need Tobias' hack-around.