Bug 357846 - cursor barely visible for rectangle region
Summary: cursor barely visible for rectangle region
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords:
: 358338 359560 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-01-11 15:09 UTC by Mathieu Jobin
Modified: 2016-10-12 20:59 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 16.04


Attachments
Breeze pointers using a dark color theme (5.96 KB, image/png)
2016-01-19 20:56 UTC, Christian Herenz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Jobin 2016-01-11 15:09:03 UTC
related to but different than https://bugs.kde.org/show_bug.cgi?id=357845

when taking a rectangle selection, I am having a very hard time seeing my cursor

I believe this is a regression from ksnapshot


Reproducible: Always

Steps to Reproduce:
1. open spectacle
2. select rectangle region
3. uncheck "on click"
4. add few seconds to the delay
5. click take new screenshot
6. select region

Actual Results:  
I am experiencing two usability regression from ksnapshot
- after I click "take a new screenshot" there is a delay before I can take the selection.
this just feels sluggish, but after the 2nd time, I accept it and it works. but with ksnapshot it was instant.
- once Its my turn to make the selection... there is now a gray filter on my screen and my selection shows unfiltered. i understand the point, you want the user to see what his screenshot will be with actual color instead of greying out the partial region he wants... but I can't see my mouse cursor on that grey screen. It hurts my eyes terrible.


Expected Results:  
make this an option, or figure it out better .... this is unusable for me.

I am going to figure out how to reinstall ksnapshot, as spectacle is unusable for me.
I just hope I won't have to downgrade everything to 15.08, that would make me very sad.
Comment 1 Simone Gaiarin 2016-01-16 07:48:22 UTC
I confirm that it's very hard to see the cursor. Would be enough to change the color of the cursor to increase the contrast with the grey area.
Comment 2 Boudhayan Gupta 2016-01-16 17:36:56 UTC
I'm downgrading the severity of this - I fail to see why this is "GRAVE". Grave is reserved for bugs that  delete all your files or kill your cat.

This may be an usability regression because the Breeze crosshair cursor really is a little difficult to see. I will experiment with lowering the intensity of the grey filter or using a white filter instead. This will be fixed one way or the other in 16.04.
Comment 3 Christian Herenz 2016-01-19 20:49:54 UTC
This occurs with the  Breeze pointers. The cross-hair in breeze snow is much better visible.
Comment 4 Christian Herenz 2016-01-19 20:56:59 UTC
Created attachment 96742 [details]
Breeze pointers using a dark color theme

The cross hair is barely visible also when using a dark color-scheme (e.g. zenburn in the attached case) I think this is not a spectacle bug, but something should be done about that cross-hair...
Comment 5 Boudhayan Gupta 2016-01-20 10:32:40 UTC
This *is* an usability bug at Spectacle's end. I intend to make the mask colour configurable - I'm undecided on whether to offer a colour selection dialog or just a choice between black and white.
Comment 6 Boudhayan Gupta 2016-01-21 15:47:44 UTC
Git commit 16018caea515baefd4a61e8a8b1624183283e9f6 by Boudhayan Gupta.
Committed on 21/01/2016 at 15:43.
Pushed by bgupta into branch 'master'.

Create a new preferences dialog and handling system.

Tunables include:
* Default save options as before
* Dynamic save button
* Remember last rectangular selection
* Use light mask colour for rectangular selection
FIXED-IN: 16.04

M  +4    -1    src/CMakeLists.txt
M  +14   -7    src/Gui/KSMainWindow.cpp
M  +1    -1    src/Gui/KSMainWindow.h
M  +7    -2    src/Gui/ScreenClipper.cpp
A  +134  -0    src/Gui/SettingsDialog/GeneralOptionsPage.cpp     [License: LGPL (v2+)]
C  +18   -27   src/Gui/SettingsDialog/GeneralOptionsPage.h [from: src/Gui/KSSaveConfigDialog.h - 056% similarity]
R  +18   -19   src/Gui/SettingsDialog/SaveOptionsPage.cpp [from: src/Gui/KSSaveConfigDialog.cpp - 085% similarity]
C  +15   -25   src/Gui/SettingsDialog/SaveOptionsPage.h [from: src/Gui/KSSaveConfigDialog.h - 064% similarity]
A  +71   -0    src/Gui/SettingsDialog/SettingsDialog.cpp     [License: LGPL (v2+)]
C  +17   -26   src/Gui/SettingsDialog/SettingsDialog.h [from: src/Gui/KSSaveConfigDialog.h - 059% similarity]
C  +10   -36   src/Gui/SettingsDialog/SettingsPage.cpp [from: src/Gui/KSSaveConfigDialog.h - 052% similarity]
R  +13   -28   src/Gui/SettingsDialog/SettingsPage.h [from: src/Gui/KSSaveConfigDialog.h - 055% similarity]
M  +39   -0    src/SpectacleConfig.cpp
M  +9    -0    src/SpectacleConfig.h

http://commits.kde.org/kscreengenie/16018caea515baefd4a61e8a8b1624183283e9f6
Comment 7 Boudhayan Gupta 2016-01-22 06:32:01 UTC
*** Bug 358338 has been marked as a duplicate of this bug. ***
Comment 8 Boudhayan Gupta 2016-02-19 10:57:04 UTC
*** Bug 359560 has been marked as a duplicate of this bug. ***
Comment 9 Joe 2016-09-14 16:10:40 UTC
Not sure if I should file a new bug, or if it is practice to reopen this one, but, I am still experiencing this issue. I have Frameworks 5.26, Plasma 5.7.5 , Applications 16.08.1, and QT 5.7.0 and run Arch/testing enabled. Basically, when I go to take a screen shot I as a rectangular region, I have click off, and no delay. It instantly darkens the screen, and the cross hair cursor is almost impossible to see using the standard Breeze cursor theme.
Comment 10 Christian Bueno 2016-10-12 18:39:35 UTC
(In reply to Simone Gaiarin from comment #1)
> I confirm that it's very hard to see the cursor. Would be enough to change
> the color of the cursor to increase the contrast with the grey area.

Hello pals , I like Breeze mouse cursor theme(default black color). It is a cross-hair very thin and it is nice. But when we want to take a screenshot of a rectangular area the cursor virtually disappear, that is because the filter is almost the same color (gray). Do you know how we can changed that filter's color?
Long live KDE plasma, Antergos, Arch linux
Comment 11 Christian Bueno 2016-10-12 18:42:57 UTC
(In reply to cherenz from comment #4)
> Created attachment 96742 [details]
> Breeze pointers using a dark color theme
> 
> The cross hair is barely visible also when using a dark color-scheme (e.g.
> zenburn in the attached case) I think this is not a spectacle bug, but
> something should be done about that cross-hair...

yes ,it is
Comment 12 Christian Bueno 2016-10-12 18:45:20 UTC
(In reply to Joe from comment #9)
> Not sure if I should file a new bug, or if it is practice to reopen this
> one, but, I am still experiencing this issue. I have Frameworks 5.26, Plasma
> 5.7.5 , Applications 16.08.1, and QT 5.7.0 and run Arch/testing enabled.
> Basically, when I go to take a screen shot I as a rectangular region, I have
> click off, and no delay. It instantly darkens the screen, and the cross hair
> cursor is almost impossible to see using the standard Breeze cursor theme.

yes , It is
Comment 13 Christian Bueno 2016-10-12 20:28:45 UTC
(In reply to Boudhayan Gupta from comment #5)
> This *is* an usability bug at Spectacle's end. I intend to make the mask
> colour configurable - I'm undecided on whether to offer a colour selection
> dialog or just a choice between black and white.

(In reply to Joe from comment #9)
> Not sure if I should file a new bug, or if it is practice to reopen this
> one, but, I am still experiencing this issue. I have Frameworks 5.26, Plasma
> 5.7.5 , Applications 16.08.1, and QT 5.7.0 and run Arch/testing enabled.
> Basically, when I go to take a screen shot I as a rectangular region, I have
> click off, and no delay. It instantly darkens the screen, and the cross hair
> cursor is almost impossible to see using the standard Breeze cursor theme.

yes , that is the same problem I have
Comment 14 Joe 2016-10-12 20:31:02 UTC
I think we need to probably open a new bug and link to this one - can't figure out how to re-open this one.
Comment 15 Christian Bueno 2016-10-12 20:51:40 UTC
(In reply to Boudhayan Gupta from comment #6)
> Git commit 16018caea515baefd4a61e8a8b1624183283e9f6 by Boudhayan Gupta.
> Committed on 21/01/2016 at 15:43.
> Pushed by bgupta into branch 'master'.
> 
> Create a new preferences dialog and handling system.
> 
> Tunables include:
> * Default save options as before
> * Dynamic save button
> * Remember last rectangular selection
> * Use light mask colour for rectangular selection
> FIXED-IN: 16.04
> 
> M  +4    -1    src/CMakeLists.txt
> M  +14   -7    src/Gui/KSMainWindow.cpp
> M  +1    -1    src/Gui/KSMainWindow.h
> M  +7    -2    src/Gui/ScreenClipper.cpp
> A  +134  -0    src/Gui/SettingsDialog/GeneralOptionsPage.cpp     [License:
> LGPL (v2+)]
> C  +18   -27   src/Gui/SettingsDialog/GeneralOptionsPage.h [from:
> src/Gui/KSSaveConfigDialog.h - 056% similarity]
> R  +18   -19   src/Gui/SettingsDialog/SaveOptionsPage.cpp [from:
> src/Gui/KSSaveConfigDialog.cpp - 085% similarity]
> C  +15   -25   src/Gui/SettingsDialog/SaveOptionsPage.h [from:
> src/Gui/KSSaveConfigDialog.h - 064% similarity]
> A  +71   -0    src/Gui/SettingsDialog/SettingsDialog.cpp     [License: LGPL
> (v2+)]
> C  +17   -26   src/Gui/SettingsDialog/SettingsDialog.h [from:
> src/Gui/KSSaveConfigDialog.h - 059% similarity]
> C  +10   -36   src/Gui/SettingsDialog/SettingsPage.cpp [from:
> src/Gui/KSSaveConfigDialog.h - 052% similarity]
> R  +13   -28   src/Gui/SettingsDialog/SettingsPage.h [from:
> src/Gui/KSSaveConfigDialog.h - 055% similarity]
> M  +39   -0    src/SpectacleConfig.cpp
> M  +9    -0    src/SpectacleConfig.h
> 
> http://commits.kde.org/kscreengenie/16018caea515baefd4a61e8a8b1624183283e9f6

Hello pal , How do you solve that problem and what means thats lines above, and the link do not show any for solve that.(In reply to Boudhayan Gupta from comment #6)
> Git commit 16018caea515baefd4a61e8a8b1624183283e9f6 by Boudhayan Gupta.
> Committed on 21/01/2016 at 15:43.
> Pushed by bgupta into branch 'master'.
> 
> Create a new preferences dialog and handling system.
> 
> Tunables include:
> * Default save options as before
> * Dynamic save button
> * Remember last rectangular selection
> * Use light mask colour for rectangular selection
> FIXED-IN: 16.04
> 
> M  +4    -1    src/CMakeLists.txt
> M  +14   -7    src/Gui/KSMainWindow.cpp
> M  +1    -1    src/Gui/KSMainWindow.h
> M  +7    -2    src/Gui/ScreenClipper.cpp
> A  +134  -0    src/Gui/SettingsDialog/GeneralOptionsPage.cpp     [License:
> LGPL (v2+)]
> C  +18   -27   src/Gui/SettingsDialog/GeneralOptionsPage.h [from:
> src/Gui/KSSaveConfigDialog.h - 056% similarity]
> R  +18   -19   src/Gui/SettingsDialog/SaveOptionsPage.cpp [from:
> src/Gui/KSSaveConfigDialog.cpp - 085% similarity]
> C  +15   -25   src/Gui/SettingsDialog/SaveOptionsPage.h [from:
> src/Gui/KSSaveConfigDialog.h - 064% similarity]
> A  +71   -0    src/Gui/SettingsDialog/SettingsDialog.cpp     [License: LGPL
> (v2+)]
> C  +17   -26   src/Gui/SettingsDialog/SettingsDialog.h [from:
> src/Gui/KSSaveConfigDialog.h - 059% similarity]
> C  +10   -36   src/Gui/SettingsDialog/SettingsPage.cpp [from:
> src/Gui/KSSaveConfigDialog.h - 052% similarity]
> R  +13   -28   src/Gui/SettingsDialog/SettingsPage.h [from:
> src/Gui/KSSaveConfigDialog.h - 055% similarity]
> M  +39   -0    src/SpectacleConfig.cpp
> M  +9    -0    src/SpectacleConfig.h
> 
> http://commits.kde.org/kscreengenie/16018caea515baefd4a61e8a8b1624183283e9f6

Hello pal , How do you solve that problem? , and what does the above lines  means?, and the link does not lead to any forum to solve the problem.
Comment 16 Joe 2016-10-12 20:59:47 UTC
I am not a developer, I think you should open a new bug (like I was thinking of doing). What you posted/linked to is a patch set that needs to be applied to the code (although I believe it already was and didn't actually solve the problem).