Bug 357796 - Two clicks needed to open Edit Brush Settings if not closed with "X"
Summary: Two clicks needed to open Edit Brush Settings if not closed with "X"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 2.9.9
Platform: Microsoft Windows Other
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-10 15:36 UTC by Glenn S
Modified: 2016-11-15 13:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
attachment-9002-0.html (2.74 KB, text/html)
2016-01-20 16:23 UTC, Glenn S
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Glenn S 2016-01-10 15:36:33 UTC
Krita 2.9.9 and Windows 10. NOT a huge bug but annoying.... If a user opens the Edit Brush Settings box, makes a choice and then starts drawing on canvas or clicks somewhere outside the box to close it, the next time the Edit Brush Settings box is needed the user has to click the icon twice or hit F5 twice to access it. 
ONLY if a user closes the EBS box by clicking on the X in top right corner can he/she then get the box to open again with ONE click or tap of F5. 
Thus, in a fast-paced painting session having to click on that small X (especially when using a 4K monitor) really slows the user down. 

Reproducible: Always

Steps to Reproduce:
1. Open Edit Brush Settings box
2. Choose Brush
3. Start painting on canvas
4. Hit F5 once (box doesn't open)
5. Hit F5 again, NOW box will open.


Actual Results:  
As above

Expected Results:  
Want Edit Brush Settings box to open with ONE click on icon or hit of F5 no matter how it was closed.
Comment 1 Halla Rempt 2016-01-20 11:33:36 UTC
Hi Glen,

I'm not sure I've understood the report correctly. Here, 

* I don't have a close button on the brush editor if it's attached to the toolbar
* if it's detached, it doesn't hide on painting, but stays on top.

So I'm a bit puzzled.
Comment 2 Glenn S 2016-01-20 16:23:46 UTC
Created attachment 96754 [details]
attachment-9002-0.html

I am unable to respond to this. My login to KDE is not being accepted - despite the fact I KNOW I am entering correct login. When attempting to reset password I am NOT being sent the reset email!!
 Glenn Slingsby
www.thirddimensionjewellery.com  

    On Wednesday, January 20, 2016 6:33 AM, Boudewijn Rempt via KDE Bugzilla <bugzilla_noreply@kde.org> wrote:
 

 https://bugs.kde.org/show_bug.cgi?id=357796

Boudewijn Rempt <boud@valdyas.org> changed:

          What    |Removed                    |Added
----------------------------------------------------------------------------
                CC|                            |boud@valdyas.org

--- Comment #1 from Boudewijn Rempt <boud@valdyas.org> ---
Hi Glen,

I'm not sure I've understood the report correctly. Here, 

* I don't have a close button on the brush editor if it's attached to the
toolbar
* if it's detached, it doesn't hide on painting, but stays on top.

So I'm a bit puzzled.
Comment 3 Glenn S 2016-01-20 18:33:49 UTC
Above comment can be deleted. This was sent by email when I couldn't log in to KDE. have now managed to get in...

My Brush Editor is NOT docked to the toolbar (is there a way to do that?) and so it DOES have a Close button.
And, no, if I have the Editor open and then start to paint on the canvas the Editor closes.


- I did later learn from Boudewijn in an email that the Brush Editor can be docked and undocked and that it shouldn't be closing even if undocked. Adding this here in case anyone else encounters similar problem.
Comment 4 Halla Rempt 2016-05-25 13:14:15 UTC
Git commit 089ac59cb51faeee5a95ff9df157576e5f488696 by Boudewijn Rempt.
Committed on 25/05/2016 at 13:13.
Pushed by rempt into branch 'master'.

Disable the preset context menu

This is broken in Qt5

M  +4    -2    libs/ui/widgets/kis_paintop_presets_popup.cpp

http://commits.kde.org/krita/089ac59cb51faeee5a95ff9df157576e5f488696
Comment 5 Scott Petrovic 2016-10-17 20:19:50 UTC
Git commit 5e3073478bd9439bf2b348dbafaab30b988cd95d by Scott Petrovic.
Committed on 17/10/2016 at 20:19.
Pushed by scottpetrovic into branch 'petrovic/brush-editor-ui'.

M  +26   -18   libs/ui/widgets/kis_paintop_presets_popup.cpp
M  +1    -0    libs/ui/widgets/kis_paintop_presets_popup.h

http://commits.kde.org/krita/5e3073478bd9439bf2b348dbafaab30b988cd95d
Comment 6 Scott Petrovic 2016-10-17 21:29:13 UTC
Git commit 842f5d33abe72c9b0e09f7f548c609f47cec4741 by Scott Petrovic.
Committed on 17/10/2016 at 21:29.
Pushed by scottpetrovic into branch 'petrovic/brush-editor-ui'.

M  +1    -1    libs/ui/forms/wdgpaintopsettings.ui
M  +12   -7    libs/ui/widgets/kis_paintop_presets_popup.cpp

http://commits.kde.org/krita/842f5d33abe72c9b0e09f7f548c609f47cec4741
Comment 7 Scott Petrovic 2016-11-15 13:06:28 UTC
Git commit 0b7be63c05b44a74cf54f5d3a5324bd6c6a7976b by Scott Petrovic.
Committed on 15/11/2016 at 12:09.
Pushed by scottpetrovic into branch 'petrovic/impex-brush-editor-ui'.

M  +1    -1    libs/ui/forms/wdgpaintopsettings.ui
M  +12   -7    libs/ui/widgets/kis_paintop_presets_popup.cpp

http://commits.kde.org/krita/0b7be63c05b44a74cf54f5d3a5324bd6c6a7976b
Comment 8 Scott Petrovic 2016-11-15 13:08:02 UTC
Git commit dc4a8b1fcc58127830f13a042a2f396cc072a021 by Scott Petrovic.
Committed on 15/11/2016 at 12:08.
Pushed by scottpetrovic into branch 'petrovic/impex-brush-editor-ui'.

M  +27   -18   libs/ui/widgets/kis_paintop_presets_popup.cpp
M  +1    -0    libs/ui/widgets/kis_paintop_presets_popup.h

http://commits.kde.org/krita/dc4a8b1fcc58127830f13a042a2f396cc072a021