Bug 357780 - git master 2016-01-10 - project fps change does not updatekeyframes on timeline
Summary: git master 2016-01-10 - project fps change does not updatekeyframes on timeline
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-10 07:02 UTC by Evert Vorster
Modified: 2019-07-30 05:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
fritzibaby: Brainstorm+


Attachments
Simple project at 25 fps. (20.48 KB, application/x-kdenlive)
2016-02-15 02:41 UTC, Evert Vorster
Details
Output from the simple project (252.39 KB, video/mp4)
2016-02-15 02:43 UTC, Evert Vorster
Details
Same simple project, as 50fps. (19.84 KB, application/x-kdenlive)
2016-02-15 02:44 UTC, Evert Vorster
Details
Output from 50fps project (169.74 KB, video/mp4)
2016-02-15 02:46 UTC, Evert Vorster
Details
Diff between original project file and 50fps one (2.97 KB, text/plain)
2016-02-15 02:49 UTC, Evert Vorster
Details
Block of text that was hend edited (205 bytes, text/plain)
2016-02-15 02:51 UTC, Evert Vorster
Details
hand edited 50fps project file (19.84 KB, application/x-kdenlive)
2016-02-15 02:52 UTC, Evert Vorster
Details
The output from the edited 50fps file (1.36 MB, video/mp4)
2016-02-15 03:06 UTC, Evert Vorster
Details
diff between the 50fps project, and the edited one (274 bytes, text/plain)
2016-02-15 03:09 UTC, Evert Vorster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Evert Vorster 2016-01-10 07:02:24 UTC
This is related to bug 350948, but spelling out this specific feature might get it fixed, as it is particularly annoying...

A clip of the bug in action can be seen on:
https://youtu.be/3tuxCnzEoz8

Reproducible: Always

Steps to Reproduce:
1.Load a clip
2.Select a segment somewhere close to the end of the clip
3.Drag into timeline. Make a good notice of what is actually occurring in the clip. 
4. Go to project settings, and double the framerate.
5. Look at the clip on the timeline again, it will now show frames from earlier in the clip

Actual Results:  
The clip on the timeline starts and stops on a different time after a fps change. 

Expected Results:  
The in and out frame numbers to be translated to the new framerate so that the segment displayed appears the same. 

related to bug: 350948
Thought you had fixed this with commit: "Fix in / out points broken when rendering a zone with an fps change"
It might still be related....
Comment 1 Evert Vorster 2016-01-18 05:53:57 UTC
This is still an issue in most recent git.
Comment 2 Evert Vorster 2016-02-15 02:41:51 UTC
Created attachment 97214 [details]
Simple project at 25 fps.

So, to get some more detail on this bug. 
I made an extremely simple project, with one clip on the timeline. 
The clip shows my drone doing a slow 360 degree rotation over my hometown.
Comment 3 Evert Vorster 2016-02-15 02:43:14 UTC
Created attachment 97215 [details]
Output from the simple project

Attached is the render from the simple project. Scaled down horribly and at poor quality to make uploading the file easy
Comment 4 Evert Vorster 2016-02-15 02:44:25 UTC
Created attachment 97216 [details]
Same simple project, as 50fps.

So, I just changed the project framerate to 50fps, and saved it again.
Comment 5 Evert Vorster 2016-02-15 02:46:45 UTC
Created attachment 97217 [details]
Output from 50fps project

So, here is the render from the 50fps project. 
As you can clearly see, it's not the same nice 360 rotation of the drone as earlier. 
The output is from much earlier inthe clip when the drone was still climbing to altitude.
Comment 6 Evert Vorster 2016-02-15 02:49:04 UTC
Created attachment 97218 [details]
Diff between original project file and 50fps one

So, I did a diff, and can see that many of the parameters have changed with the framerate change.
Comment 7 Evert Vorster 2016-02-15 02:51:41 UTC
Created attachment 97219 [details]
Block of text that was hend edited

So, I edited the 50fps project by hand, and change the in and out frames in that block of text with the following formula:
(in_keyframe/original_framerate)*new_framerate=new_in_keyframe
Comment 8 Evert Vorster 2016-02-15 02:52:35 UTC
Created attachment 97220 [details]
hand edited 50fps project file

The new project file, hand customised
Comment 9 Evert Vorster 2016-02-15 03:06:07 UTC
Created attachment 97221 [details]
The output from the edited 50fps file

Here is the output file from the hand-edited file, this time with a little higher bit of quality. 
As you can see, it's the same 360 rotation as in the 25fps one.
Comment 10 Evert Vorster 2016-02-15 03:09:07 UTC
Created attachment 97222 [details]
diff between the 50fps project, and the edited one

So, here is the diff between the two files. 
It would be great to have the bugs taken out of the change fps of a project feature. 
There may be other little bugs, and I will report them in a similar manner, but let's get this fix in first, please?
This fix should be quite an easy one, as while the project is loaded, all the variables are in memory and easy to modify.
Comment 11 Andrew Crouthamel 2018-09-25 21:53:25 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 12 Evert Vorster 2018-09-26 04:29:24 UTC
Dear Andrew, changing status to REPORTED as I am the last submitter on this bug, awaiting an answer from the developers.

I can confirm the bug still exists, and is rather severe for anyone who mixes clips with different framerates. 

-Evert--
Comment 13 Evert Vorster 2019-07-30 05:12:20 UTC
Fixed! Thanks, JBM...