Bug 357678 - Hide MIME type tab bar when only one option exists
Summary: Hide MIME type tab bar when only one option exists
Status: RESOLVED INTENTIONAL
Alias: None
Product: trojita
Classification: Applications
Component: Desktop GUI (other bugs)
Version First Reported In: git
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Trojita default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-07 23:31 UTC by Luke-Jr
Modified: 2016-01-08 19:20 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke-Jr 2016-01-07 23:31:38 UTC
A tab bar with only "Plaintext" and doubling the margins (one above and one below) wastes a lot of screen space.

Reproducible: Always
Comment 1 Jan Kundrát 2016-01-08 07:48:56 UTC
This is by design, to show the MIME structure of the message. While I agree that it's probably useless for a regular user, it's a nice toy, IMHO. It would also be too much work to change this "elegantly" without introducing other kludges.

The margins are taken from your system's settings (Qt's settings and its style and its settings, to be specific). Maybe there's an option to tweak these for your entire system?
Comment 2 Thomas Lübking 2016-01-08 10:58:10 UTC
Hah? This would be a multipart message w/ only one part, would it?
(I do absolutely not get this in singlepart mails)

Might be a misconfigured server (along bug #357676) if this is the "regular" case for you?
Comment 3 Luke-Jr 2016-01-08 16:03:06 UTC
The margins are reasonable for having a tabbed widget there. The problem is just the useless tab widget existing in the first place...

Yes, it's a multipart message with one part.

Guess I can go back to KMail again if user-friendliness has become WONTFIX. :/
Comment 4 Thomas Lübking 2016-01-08 16:39:44 UTC
(In reply to Luke-Jr from comment #3)

> Guess I can go back to KMail again if user-friendliness has become WONTFIX.
> :/

This kind of "argumentation" will not help you at all. No idea about Jan, but I'm very quick adding people to SA w/ a special tag, what means you stay forever (and bugzilla mails still expose the reporters address)
So do yourself a favor and try to keep ad rem, ok?

So, ON topic:
---------
a) Why do you get a multipart message w/ only one part?
I'd frankly seek to fix that first - is it your own Courier IMAP server?

b) Leaving that aside, showing a tabbar w/ only one entry is pointless. A multipart mail w/ only one part is more or less a bug, but there's no reason to expose that to the common user this way.

@Jan
Fix should be very simple: QTabWidget::setTabBarAutoHide(true) - requires Qt 5.4, though.
Comment 5 Luke-Jr 2016-01-08 18:43:27 UTC
a) I assume because the sender formatted it that way...
Comment 6 Thomas Lübking 2016-01-08 19:20:35 UTC
Depends.
If that's limited to one sender: likely.

Otherwise it might be a bug in the IMAP server (I took your concern as indicator that this happens on a more regular base. If I get malformatted spam, I don't care. It's going /dev/null - malformatted or not ;-)