Bug 357659 - 15.13: Bézier curve UI broken: looses settings, second handle of bottom-left point non-accessible
Summary: 15.13: Bézier curve UI broken: looses settings, second handle of bottom-left ...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-07 16:42 UTC by Wegwerf
Modified: 2016-01-08 17:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 15.12.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-01-07 16:42:10 UTC
The user interface for the Bézier curve effect is broken in several ways:

1. Initially (and whenever returning to this effect) the top-right and bottom-left points are accessible, but the helper pointers are outside the effect's UI window.
2. When leaving the effect by selecting something else and on return all settings for the effect are lost. As soon as the user tries to edit the Bézier curve, all settings are reset.
3. Albeit the background coloring is enabled by default, only a black background in the effect's graph UI is shown. Toggling twice makes the color background appear, albeit always the first one. Changing the channel to work on does not change the UI coloring.

Note: I'm using locale DE_de, where the fraction separator is "," instead of ".".

Reproducible: Always

Steps to Reproduce:
1. Create Kdenlive project.
2. Add any clip to it.
3. Add Bézier Curve effect.
4. Try to change the handles.
5. Try to change the channel.

Actual Results:  
1. Handles are outside the UI graph region and thus inaccessible using the mouse.
2. UI graph background color is missing or does not change accordingly to channel selected.
3. Settings are lost when leaving the effect and later returning to it.

Expected Results:  
1. Initial all four handles should be accessible from the UI using the mouse.
2. UI should show colored background according to channel selected.
3. Settings must not be lost when leaving the effect and later returning to it.
Comment 1 Jean-Baptiste Mardelle 2016-01-07 21:42:11 UTC
Thanks, issue 3 is indeed a locale issue. 
Will try to at least fix this one in the next 2 hours before 15.12.1 freeze!
Comment 2 Jean-Baptiste Mardelle 2016-01-07 21:58:21 UTC
Git commit fe7a8586e7d65578125d40dd2cb45a867cade303 by Jean-Baptiste Mardelle.
Committed on 07/01/2016 at 21:57.
Pushed by mardelle into branch 'Applications/15.12'.

Fix Bézier spline broken on locales with numerical separator != .
Fix Bézier colors with dark themes

M  +2    -2    src/effectstack/widgets/bezier/beziersplineeditor.cpp
M  +2    -2    src/effectstack/widgets/bezier/cubicbezierspline.cpp
M  +13   -32   src/effectstack/widgets/kis_curve_widget.cpp
M  +0    -6    src/effectstack/widgets/kis_curve_widget_p.h

http://commits.kde.org/kdenlive/fe7a8586e7d65578125d40dd2cb45a867cade303
Comment 3 Jean-Baptiste Mardelle 2016-01-07 22:30:35 UTC
Git commit dfa63991e2a59107d192983085d54da0ff8e5d37 by Jean-Baptiste Mardelle.
Committed on 07/01/2016 at 22:30.
Pushed by mardelle into branch 'Applications/15.12'.

Fix colored background not displayed in Bézier effect

M  +1    -1    data/effects/frei0r_curves.xml
M  +2    -1    src/effectstack/parametercontainer.cpp
M  +9    -11   src/effectstack/widgets/bezier/beziersplinewidget.cpp
M  +1    -1    src/effectstack/widgets/bezier/beziersplinewidget.h

http://commits.kde.org/kdenlive/dfa63991e2a59107d192983085d54da0ff8e5d37
Comment 4 Wegwerf 2016-01-08 14:13:16 UTC
Tested: works. Thank you very much for fixing this old regression so quickly!