Bug 357625 - Please add popup menu with "Add bookmark"
Summary: Please add popup menu with "Add bookmark"
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.23.0
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-06 17:56 UTC by Victor Porton
Modified: 2022-02-01 20:45 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 22.04
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Porton 2016-01-06 17:56:56 UTC
Please add to the Bookmarks sidebar popup menu with "Add bookmark" (now there is only a menu which is shown when right-clicking a particular bookmarks and no menu when right-clicking the empty space; these should be unified).

Reproducible: Always
Comment 1 Albert Astals Cid 2016-01-06 22:12:39 UTC
I don't understand what you mean, please try to explain it with different words.
Comment 2 Victor Porton 2016-01-06 22:19:40 UTC
When right clicked in the bookmarks sidebar (either clicking a bookmark or clicking the empty area), there should appear a menu with "Add bookmark" item.
Comment 3 Albert Astals Cid 2016-01-06 22:25:41 UTC
Why? It's not somewhere you'd go to add a boomark, it's much easier to rightclick on the page itself to add a bookmark than to move the mouse out to the bookmarks sidebar and right click there, no?
Comment 4 Victor Porton 2016-01-06 22:27:25 UTC
It should work both ways, to streamline user's experience with no need to remember which part of the window he or she needs to right-click.
Comment 5 Nate Graham 2022-02-01 20:38:26 UTC
Git commit 01557c16c4e5e66036cc1602d85dfb24ed68ebd5 by Nate Graham.
Committed on 01/02/2022 at 19:58.
Pushed by ngraham into branch 'master'.

Put an "Add Bookmark" button on the Bookmarks sidebar

Previously, the only ways to add a bookmark were with the menu item or
keyboard shortcut. This commit adds a button at the bottom of the
bookmarks sidebar to do the same thing, which seems like a logical place
for such functionality.

setupViewerActions() was moved to earlier in the setup process to ensure
that m_addBookmark is assigned by the time the bookmarks sidebar is
created, since it gets passed that action in its constructor.
FIXED-IN: 21.12

M  +3    -1    part/bookmarklist.cpp
M  +1    -1    part/bookmarklist.h
M  +3    -3    part/part.cpp

https://invent.kde.org/graphics/okular/commit/01557c16c4e5e66036cc1602d85dfb24ed68ebd5