Bug 357588 - should use NetworkManager online status
Summary: should use NetworkManager online status
Status: REPORTED
Alias: None
Product: choqok
Classification: Applications
Component: general (show other bugs)
Version: 1.5
Platform: Debian testing Linux
: LO wishlist
Target Milestone: ---
Assignee: Mehrdad Momeny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-05 18:17 UTC by Lisandro Damián Nicanor Pérez Meyer
Modified: 2021-03-09 01:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lisandro Damián Nicanor Pérez Meyer 2016-01-05 18:17:44 UTC
Original bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809600

Dominik reported:

  Choqok autostarts with my KDE session and then immediately tries to load
  messages. If this happens before I connect to a network, Choqoks pops up
  an alert that it cannot resolve the server address.
  .
  NetworkManager provides a D-Bus interface to check whether the system is
  connected to the network, so applications like Choqok can verify that
  before trying anything like DNS or conecting to any servers.
  .
  Choqok should use this interface in order to not nag the user with
  unnecessary errors.

I will add to the above that this should happen only if NM is detected running. Not everyone uses NM.

Reproducible: Always
Comment 1 Andrea Scarpino 2016-01-06 12:21:10 UTC
KDE provides a "Network Status" service to query, well, network status. If we already don't, we should use it.
Comment 2 Mehrdad Momeny 2016-01-09 06:32:29 UTC
Well, I tried this here, (logging into KDE while the networking is disabled and clicking on Update Timelines menu option to update) but in both cases, it does not show connection error as a popup message box. just report it in a message in Choqok window's status bar.
And I do remember that we had only one message showing in start-up time, and it was eliminated some time ago. and upon re-checking the source codes, I see only message box errors in cases where user is interacting with the app. (e.g. posting a tweet)

While the idea of checking if system is connected looks nice, I don't think it worth the hassle, considering that every module in Choqok is now contacting directly something on the network to load some stuff.
Comment 3 Justin Zobel 2021-03-09 01:26:56 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.