In KDE4 the selection marker was a big fat green + that was easy to see and use. In KDE5 it is changed to a 1px wide +. When I upgraded to KDE5, initially I assumed that there are no selection markers in Dolphin anymore. It took me 2 weeks to notice those small things. Please revert this change. Reproducible: Always
Thanks for the report. This is a Breeze issue. You will get the bigger "+" icon again if you switch to the Oxygen icon theme.
hi miklos this is not a breeze issue it's an breeze design guideline. all icons use a 1px thin line. for dolphin it would be possible to use emblem icons they are designed for overlay stuff. As I'm the maintainer of oxygen icons I can add the needed icons in breeze icons and oxygen icons if the dolphin developers want to change the icon name for the overlay icons.
(In reply to andreas from comment #2) > hi miklos this is not a breeze issue it's an breeze design guideline. all > icons use a 1px thin line. for dolphin it would be possible to use emblem > icons they are designed for overlay stuff. It's not an icon, it's a control. Controls need to be easily visible (well, so do icons...). Just take a look at the folder view plasmoid to see how it's done right.
As I work for breeze and oxygen I can offer you this solution. Please change the icon name to emblem-add and emblem-remove. I will push the icons in breeze-icons and oxygen-icons. thanks
Thanks for the info, Andreas. It seems it is a Dolphin issue then. Just one question: Do I understand correctly that these icons are not part of breeze-icons and oxygen-icons yet (you said that you are going to push them)? This would mean that Dolphin can only switch to these icons once it can depend on a release of the icons packages that contains these new icons. BTW, I did look at FolderView's QML code and found this in FolderItemDelegate.qml in a FolderItemActionButton object, which looks at first sight like it's the "selection toggle": element: model.selected ? "remove" : "add" I guess that "remove" and "add" are not the full icon names though.
correct they aren't in breeze-icons or oxygen-icons now. but they will released every month with frameworks. the icons from the FolderView is not from the icon theme it's from the plasma theme.
Ok, thanks for the quick reply! This means that Dolphin needs to raise its required KDE Frameworks version once such a change is made.
*** Bug 359926 has been marked as a duplicate of this bug. ***
please use the 8x8 px icons emblem-added and emblem-remove icons. If you want I can add this icons in oxygen as well but kf5 and plasma 5 only support breeze icons. https://bugs.kde.org/show_bug.cgi?id=360330
(In reply to andreas from comment #9) > please use the 8x8 px icons emblem-added and emblem-remove icons. If you > want I can add this icons in oxygen as well but kf5 and plasma 5 only > support breeze icons. > > https://bugs.kde.org/show_bug.cgi?id=360330 Thanks for the nice icons :) Does the next KF5 release, which will be released this weekend, contain those icons? Otherwise we have to wait for next applications release cycle.
The icons were pushed to breeze on 9.3. and KF 5.20 is not released yet. I think it will be released on 13.3. So I also add the oxygen emblem-xxx icons and when you change the names in Dolphin it will work in breeze, breeze-dark and oxygen.
(In reply to andreas from comment #11) > The icons were pushed to breeze on 9.3. and KF 5.20 is not released yet. I > think it will be released on 13.3. So I also add the oxygen emblem-xxx icons > and when you change the names in Dolphin it will work in breeze, breeze-dark > and oxygen. The commit was after the 5.20 tag, so it will be released with KF 5.21. This means that we have to wait for the next release of KDE applications before we can make use of them.
sorry. than I will make a dolphin review and hope we can fix some other issues for the next release.
Git commit 8b9811694df60146a9d467305690bdf0425e428e by Emmanuel Pescosta. Committed on 09/04/2016 at 12:23. Pushed by emmanuelp into branch 'master'. Selection toggle: Use emblem-remove and emblem-added icons from Breeze This raises the minimum KF5 version to 5.21.0 FIXED-IN: 16.08.0 REVIEW: 127400 CCMAIL: kainz.a@gmail.com M +1 -1 CMakeLists.txt M +1 -1 src/kitemviews/private/kitemlistselectiontoggle.cpp http://commits.kde.org/dolphin/8b9811694df60146a9d467305690bdf0425e428e