I have a pretty complicated filter stack that does not change much between render jobs, so I saved it. The filter stack consists of: De-fish, Levels, White balance, Saturation, Sharpening. None of these effects take key frames when first applied. However, when the entire stack is saved and applied to another clip, they suddenly have key frames. Worse, the key frames is for the frame numbers of the previous clip, and if this happens to be after the last frame of the current clip, the effects are applied at their highest negative setting. Reproducible: Always Steps to Reproduce: 1. Make a filter stack a few levels deep. Save it as a custom one. 2. Apply the filter stack to another clip, and look at the frame numbers the effects in the stack have now suddenly gained. 3. Add one more keyframe, and delete the original keyframe. 4. The keyframes now disappear for the selected effect in the stack. Actual Results: Effects stack does not apply without fiddling, and looks different from the one that was saved. Expected Results: The effect stack to be key frame agnostic, just like the one I saved. This is a little annoying, and I found half a workaround by making the effect stack on the first frame of a clip, and then saving it. Then the effect stack is applied each time, at least. However the key frames remain until I pick a key frame in the clip, and delete the others. This could actually be quite a nifty feature, if it was possible to leave the key frames add button to each effect, and then just interpolate between the key frames if more than one key frame is added. However, the key frames should be adjusted to the first frame of the clip that the effect is being applied to, as specifying a key frame that is not in the range of the clip does not make sense. Also, the frame with the key frames in should also be hidden when there is only one key frame, to save screen space. It is then assumed that the effect does not change for the entire. If the button for adding more key frames is left in, and expose the key frame window when another key frame is added, it could be quite a feature at almost no extra coding cost.
I've noticed this before too; it also seems to happen when copying and pasting effects within an project from one clip to another. However, sometimes the improper keyframe translation kicks in, sometimes not. I still need to find out exactly when this happens.
I have uploaded a clip of where I play with this bug. The first bit I am just getting rid of the keyframe dialog on the effects, and showing that it can be a bit of a schlepp with a large filter stack. However, this bug also exposes a powerful feature, where every filter can be keyframed. In the rest of the uploaded clip I am keyframing "Defish", which is not normally keyframeable. So, it's possible, and would be a very powerful feature. The clip is uploaded at https://youtu.be/et1c2gB6k3g
Git commit ee7a170a5af9bd94498eb8458e8e6a1c6ff68ea0 by Jean-Baptiste Mardelle. Committed on 13/01/2016 at 23:45. Pushed by mardelle into branch 'master'. Fix keyframes sometimes broken when copy/paste M +23 -5 src/mltcontroller/effectscontroller.cpp M +2 -3 src/mltcontroller/effectscontroller.h M +2 -14 src/timeline/customtrackview.cpp http://commits.kde.org/kdenlive/ee7a170a5af9bd94498eb8458e8e6a1c6ff68ea0
Fixed... Thanks for the fix, but..... I would still like to be able to add keyframes to some effects that don't have them now.
Just to be sure, the Defish effect is keyframable, like all freior effects. You must click on the small clock icon above parameter to display the keyframes list. Currently keyframes handling is a bit inconsistent in Kdenlive because there are several UIs, but I hope we can work on improving the keyframes ui during our next coding sprint