Bug 357374 - Huge Skype and Google Talk icons in Contacts panel view
Summary: Huge Skype and Google Talk icons in Contacts panel view
Status: RESOLVED FIXED
Alias: None
Product: kaddressbook
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-31 20:00 UTC by André Marcelo Alvarenga
Modified: 2016-02-12 19:58 UTC (History)
3 users (show)

See Also:
Latest Commit: http://commits.kde.org/kdepim-apps-libs/b11fcb0639921df8353345e006cef463ec01c382
Version Fixed In: 5.1.3

Attachments
Screenshot (34.20 KB, image/png)
2015-12-31 20:01 UTC, André Marcelo Alvarenga 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description André Marcelo Alvarenga 2015-12-31 20:00:53 UTC 
See screenshot.

There is a big generic icon to Facebook and Twitter too.

Reproducible: Always
Comment 1 André Marcelo Alvarenga 2015-12-31 20:01:34 UTC 
Created attachment 96389 [details]
Screenshot
Comment 2 André Marcelo Alvarenga 2015-12-31 20:07:00 UTC 
KAddresBook 5.1 (KDE Applications 15.12)
Comment 3 Laurent Montel 2016-01-01 11:31:12 UTC 
indeed it's a big icon !
Comment 4 Jonathan Marten 2016-01-06 19:35:07 UTC 
Think I implemented the display of these icons, 2 years ago for KDE4.  Assuming that the code is mostly unchanged, it does:

const QString iconUrl = KUrl::fromPath( KIconLoader::global()->iconPath(
      IMProtocols::self()->icon( typeKey ), -KIconLoader::SizeSmall) ).url();
const QString url = QString::fromLatin1( "<img src=\"%1\" align=\"top\"/>" ).arg( iconUrl );

It tries to force the appropriate small size, but it's not certain what happens if there is no icon of that size available, only larger ones - if the returned path points to a larger icon then that is what will be seen.  If so, would setting an explicit width= and height= in the HTML fragment work?
Comment 5 Laurent Montel 2016-02-12 19:58:17 UTC 
Git commit b11fcb0639921df8353345e006cef463ec01c382 by Montel Laurent.
Committed on 12/02/2016 at 19:58.
Pushed by mlaurent into branch 'master'.

Fix Bug 357374 - Huge Skype and Google Talk icons in Contacts panel view
FIXED-IN: 5.1.3

M  +1    -1    kaddressbookgrantlee/src/formatter/grantleecontactformatter.cpp

http://commits.kde.org/kdepim-apps-libs/b11fcb0639921df8353345e006cef463ec01c382