Bug 357322 - Clip Properties: rounded frame rate, b/s vs kb/s, superfluous digit in audio bitrate
Summary: Clip Properties: rounded frame rate, b/s vs kb/s, superfluous digit in audio ...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-30 03:38 UTC by qubodup
Modified: 2018-10-13 10:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot showing discrepancy between clip properties and ffprobe information (277.60 KB, image/png)
2015-12-30 03:38 UTC, qubodup
Details

Note You need to log in before you can comment on or make changes to this bug.
Description qubodup 2015-12-30 03:38:27 UTC
Created attachment 96363 [details]
screenshot showing discrepancy between clip properties and ffprobe information

Clip properties appears to rounds frame rate to one decimal digit. This turns 59.94 into 59.9 and 29.97 into 30.

1. (issue) frame rate should not be rounded or possibly only rounded to two decimal digits.

A workaround is to use external software to find out the actual frame rate.

2. (suggestion) ffprobe reports audio bit rate without decimal digits, i would suggest using the same format.
 
3. (suggestion) I would suggest using kb/s rather than b/s for Bitrate (without decimal digits), since ffprobe does the same. Possibly with b/s as a mouse-hover tooltip.
Comment 1 Jean-Baptiste Mardelle 2015-12-30 22:39:58 UTC
Git commit 65f5f6544cff77e2016e8003e9ebe051d19dd1f2 by Jean-Baptiste Mardelle.
Committed on 30/12/2015 at 22:39.
Pushed by mardelle into branch 'Applications/15.12'.

Fix wrong rounding and other small issues in clip properties display

M  +14   -13   src/mltcontroller/clippropertiescontroller.cpp

http://commits.kde.org/kdenlive/65f5f6544cff77e2016e8003e9ebe051d19dd1f2
Comment 2 qubodup 2015-12-31 07:50:19 UTC
Thanks!
- As a quick test: 59.94 and 29.97 are the same both in Kdenlive clip properties and ffprobe.
- 23.98 (ffprobe) is now reported as 23.976 in the properties. Not sure if there's an issue there.
- I noticed that Audio and Video bitrates are now in kb/s rather than KiB/s but the "Bitrate" is still in bits/s though without "b/s" (ffmpeg uses "kb/s" for all three it seems)
Comment 3 Jean-Baptiste Mardelle 2015-12-31 09:07:01 UTC
Git commit c459544a4b8d88b4e2c2ad1109bc43ae413eade8 by Jean-Baptiste Mardelle.
Committed on 31/12/2015 at 09:06.
Pushed by mardelle into branch 'master'.

Fix Bitrate unit

M  +8    -1    src/mltcontroller/clippropertiescontroller.cpp

http://commits.kde.org/kdenlive/c459544a4b8d88b4e2c2ad1109bc43ae413eade8
Comment 4 qubodup 2016-01-06 04:04:19 UTC
Thanks!

Two possible small issues:
1. (cosmetic) "Frame rate" values are missing " fps" at the end (ffprobe has it)
2. (not sure) "Bitrate" might be better as "Total bitrate", at least that's what the author of  http://video.stackexchange.com/questions/11955/ used to differentiate between audio, video and total bitrate.
Comment 5 qubodup 2016-01-07 02:14:29 UTC
Just for future reference: a 4K video made with a Samsung Galaxy Note 4 reports as 29.99 fps in ffprobe but as Frame rate 29.9898 in kdenlive-git 15.13.0.r6866.e43f3d4-1. I don't know why it has such a weird fps and I can't check (was a rental device).
Comment 6 Wegwerf 2016-07-31 09:16:16 UTC
Qubodup, is this bug report still relevant, or can we close it?