Bug 357157 - Marble crashes while trying to open .osm files using the open file icon in Edit Maps Panel.
Summary: Marble crashes while trying to open .osm files using the open file icon in Ed...
Status: RESOLVED WORKSFORME
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian stable Linux
: NOR crash
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-25 19:40 UTC by sutirtha
Modified: 2021-01-03 04:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
nienhueser: Backport+


Attachments
the .osm file that causes the crash (911 bytes, text/plain)
2015-12-25 19:46 UTC, sutirtha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sutirtha 2015-12-25 19:40:48 UTC
The .osm file successfully opens if i use Files->Open menu option but crashes when  i use the open options from Edit Maps panel.

Reproducible: Always

Steps to Reproduce:
1.Create a .osm file by editing the file from the Edit Maps Panel
2.Try to open the same file use open option in the panel
3.Marble Crashes
Comment 1 sutirtha 2015-12-25 19:46:37 UTC
Created attachment 96299 [details]
the .osm file that causes the  crash
Comment 2 Dennis Nienhüser 2016-01-16 12:18:45 UTC
Seems to be some kind of race condition. Commenting m_parsingTasks[i]->deleteLater(); in ParsingRunnerManager::Private::cleanupParsingTask works around it.
Comment 3 Dennis Nienhüser 2016-01-16 15:57:25 UTC
Git commit 31f7b982736eaece5a8d9958f1aca06dedc630be by Dennis Nienhüser.
Committed on 16/01/2016 at 15:57.
Pushed by nienhueser into branch 'master'.

Fix a crash when using the blocking API of ParsingRunnerManager

Both QThreadPool and ParsingRunnerManager were trying to delete the
same class instance. Now ParsingRunnerManager only keeps track of
the number of active parsers, but does not attempt to delete them
once they finish.

A simpler fix would have been to call setAutoDelete(false) in the
ParsingTask ctor, but this approach seems cleaner.

M  +15   -19   src/lib/marble/ParsingRunnerManager.cpp
M  +1    -2    src/lib/marble/ParsingRunnerManager.h
M  +1    -1    src/lib/marble/RunnerTask.cpp
M  +1    -1    src/lib/marble/RunnerTask.h

http://commits.kde.org/marble/31f7b982736eaece5a8d9958f1aca06dedc630be
Comment 4 Justin Zobel 2020-12-04 05:11:01 UTC
Thank you for the report.

As it has been a while since this was reported, can you please test and confirm if this issue is still occurring or if this bug report can be marked as resolved.

I have set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved/worksforme" when you respond, thank you.
Comment 5 Bug Janitor Service 2020-12-19 04:34:58 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2021-01-03 04:34:25 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!