Bug 357082 - Button for closing notifications should not be a circle within a circle
Summary: Button for closing notifications should not be a circle within a circle
Status: RESOLVED WORKSFORME
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.5.1
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-12-23 00:47 UTC by Thomas Pfeiffer
Modified: 2018-10-27 03:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Pfeiffer 2015-12-23 00:47:55 UTC 
With the Breeze Plasma and icon themes, currently the button to close a notification shows a red circle icon within a circle button frame, which looks really weird.
Uri confirmed that it's supposed to just be the icon without a border around it (though the hit area should stay the same)

Reproducible: Always
Comment 1 Martin Klapetek 2015-12-23 01:38:27 UTC 
Thanks for the report

This is due to PlasmaComponents.ToolButton being a circle
if the "flat" property is true. I can sure fix the notifications
popups but you might want to consider if perhaps all flat
ToolButtons shouldn't be a circle?
Comment 2 Thomas Pfeiffer 2016-01-04 18:14:33 UTC 
The form of the button isn't the problem. The problem is that it has a border at all. The icon was designed to _be_ the button, not to be _inside_ the button. It should fill the whole button, and there should not be a border around it.
Comment 3 Martin Klapetek 2016-01-04 18:25:39 UTC 
> The icon was designed to _be_ the button

Icons really shouldn't be designed as controls, imho. That's a theme bug then.
Comment 4 Andrew Crouthamel 2018-09-25 21:45:32 UTC 
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Andrew Crouthamel 2018-10-27 03:34:38 UTC 
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!